Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta issue #500866: [META] remove t() from assert message.
Comment | File | Size | Author |
---|---|---|---|
#20 | 1797506-20-t-rdf.patch | 28.76 KB | dcam |
#18 | 1797506_remove_t_assertTrue_18.patch | 28.67 KB | Sivaji_Ganesh_Jojodae |
#9 | 1797506-9-t-rdf.patch | 28.67 KB | dcam |
#4 | 1797506-4-t-rdf.patch | 30.8 KB | Lars Toomre |
#4 | interdiff-1797506-1-4.txt | 703 bytes | Lars Toomre |
Comments
Comment #1
xjmIn
CommentAttributesTest
(which belongs tordf.module
, but extendsCommentTestBase
), there is a use ofsetCommentSettings()
with a translated message parameter. I left that out of this patch; it should be addressed in #1798066: Clean up CommentTestBase::setCommentSettings().Comment #3
xjmOops.
I'll fix this later (or someone else is welcome to).
Comment #4
Lars Toomre CreditAttribution: Lars Toomre commentedAll of the changes in #1 look good and complete to me. However, since this issue also needed to be fixed for an extra ')', I am leaving this issue to someone else to also review and approve.
Here is a patch and interdiff addressing #3.
Comment #5
dcam CreditAttribution: dcam commented#4 looks good. I didn't find any more t()'s around assert messages in the RDF module.
Comment #6
Lars Toomre CreditAttribution: Lars Toomre commentedThanks for the review @dcam. I rolled a new patch with additions you asked for in the Node sub-issue.
Comment #7
webchickTum te tum...
Comment #8
jhodgdonThis one's committed, thanks all! Ready for port...
Comment #9
dcam CreditAttribution: dcam commentedBackported #4 to D7.
Comment #10
dcam CreditAttribution: dcam commented#9: 1797506-9-t-rdf.patch queued for re-testing.
Comment #11
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #12
scor CreditAttribution: scor commentedthis backport is good to go.
Comment #13
dcam CreditAttribution: dcam commentedThanks for the review, scor!
Comment #14
scor CreditAttribution: scor commentedThis will need a reroll due to #1848464: Make RDFa markup upward compatible with RDFa 1.1.
Comment #15
xjm#9: 1797506-9-t-rdf.patch queued for re-testing.
Comment #17
xjmComment #18
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedPatch #9 re-rolled.
Comment #20
dcam CreditAttribution: dcam commentedRerolled #9.
Comment #21
scor CreditAttribution: scor commentedthanks @dcam. this looks good.
Comment #22
YesCT CreditAttribution: YesCT commentedremoving reroll tag. we can add it back later if we need it.
Comment #23
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/673aa4d