Remove t() from assertion messages in tests for the rdf module

Part of meta issue #500866: [META] remove t() from assert message.

Comment	File	Size	Author
#20	1797506-20-t-rdf.patch	28.76 KB	dcam
#18	1797506_remove_t_assertTrue_18.patch	28.67 KB	sivaji_ganesh_jojodae
#9	1797506-9-t-rdf.patch	28.67 KB	dcam
#4	1797506-4-t-rdf.patch	30.8 KB	lars toomre
#4	interdiff-1797506-1-4.txt	703 bytes	lars toomre
#1	rdf-1797506-1.patch	30.81 KB	xjm

Comments

Comment #1

xjm

she/her

English

commented 28 September 2012 at 16:19

Assigned:	xjm	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	rdf-1797506-1.patch	30.81 KB

In CommentAttributesTest (which belongs to rdf.module, but extends CommentTestBase), there is a use of setCommentSettings() with a translated message parameter. I left that out of this patch; it should be addressed in #1798066: Clean up CommentTestBase::setCommentSettings().

Log in or register to post comments

Comment #2

28 September 2012 at 16:39

Status:

Needs review

» Needs work

The last submitted patch, rdf-1797506-1.patch, failed testing.

Log in or register to post comments

Comment #3

xjm

she/her

English

commented 28 September 2012 at 17:27

Oops.

 Output: [PHP Parse error:  syntax error, unexpected ')' in ./core/modules/rdf/lib/Drupal/rdf/Tests/RdfaMarkupTest.php on line 167

I'll fix this later (or someone else is welcome to).

Log in or register to post comments

Comment #4

lars toomre commented 30 September 2012 at 06:25

Status:

Needs work

» Needs review

Status	File	Size
new	interdiff-1797506-1-4.txt	703 bytes
new	1797506-4-t-rdf.patch	30.8 KB

All of the changes in #1 look good and complete to me. However, since this issue also needed to be fixed for an extra ')', I am leaving this issue to someone else to also review and approve.

Here is a patch and interdiff addressing #3.

Log in or register to post comments

Comment #5

dcam commented 18 October 2012 at 05:59

Status:

Needs review

» Reviewed & tested by the community

#4 looks good. I didn't find any more t()'s around assert messages in the RDF module.

Log in or register to post comments

Comment #6

lars toomre commented 18 October 2012 at 06:17

Thanks for the review @dcam. I rolled a new patch with additions you asked for in the Node sub-issue.

Log in or register to post comments

webchick’s picture

Comment #7

she/they

English

Vancouver 🇨🇦

commented 18 October 2012 at 07:10

Assigned:

Unassigned

Tum te tum...

Log in or register to post comments

jhodgdon’s picture

Comment #8

she/her

English

commented 18 October 2012 at 23:20

Version:	8.x-dev	» 7.x-dev
Assigned:	jhodgdon	» Unassigned
Status:	Reviewed & tested by the community	» Patch (to be ported)

This one's committed, thanks all! Ready for port...

Log in or register to post comments

Comment #9

dcam commented 22 October 2012 at 06:02

Status:

Patch (to be ported)

» Needs review

Status	File	Size
new	1797506-9-t-rdf.patch	28.67 KB

Backported #4 to D7.

Log in or register to post comments

Comment #10

dcam commented 26 February 2013 at 06:34

#9: 1797506-9-t-rdf.patch queued for re-testing.

Log in or register to post comments

Comment #11

dcam commented 28 February 2013 at 05:33

Issue tags:

Tagging as Novice.

Log in or register to post comments

scor’s picture

Comment #12

scor commented 9 March 2013 at 20:07

Status:	Needs review	» Reviewed & tested by the community
Issue tags:		+SprintWeekend2013

this backport is good to go.

Log in or register to post comments

Comment #13

dcam commented 9 March 2013 at 20:30

Thanks for the review, scor!

Log in or register to post comments

scor’s picture

Comment #14

scor commented 11 March 2013 at 16:09

Status:

Reviewed & tested by the community

» Needs work

This will need a reroll due to #1848464: Make RDFa markup upward compatible with RDFa 1.1.

Log in or register to post comments

Comment #15

xjm

she/her

English

commented 12 March 2013 at 12:34

Status:	Needs work	» Needs review
Issue tags:	-Novice, -Needs backport to D7, -SprintWeekend2013

#9: 1797506-9-t-rdf.patch queued for re-testing.

Log in or register to post comments

Comment #16

12 March 2013 at 12:36

Status:	Needs review	» Needs work
Issue tags:		+Novice, +Needs backport to D7, +SprintWeekend2013

The last submitted patch, 1797506-9-t-rdf.patch, failed testing.

Log in or register to post comments

Comment #17

xjm

she/her

English

commented 12 March 2013 at 14:36

Issue tags:

Log in or register to post comments

sivaji_ganesh_jojodae’s picture

Comment #18

sivaji_ganesh_jojodae commented 16 March 2013 at 18:31

Status:

Needs work

» Needs review

Status	File	Size
new	1797506_remove_t_assertTrue_18.patch	28.67 KB

Patch #9 re-rolled.

Log in or register to post comments

Comment #19

16 March 2013 at 18:33

Status:

Needs review

» Needs work

The last submitted patch, 1797506_remove_t_assertTrue_18.patch, failed testing.

Log in or register to post comments

Comment #20

dcam commented 24 March 2013 at 23:43

Status:

Needs work

» Needs review

Status	File	Size
new	1797506-20-t-rdf.patch	28.76 KB

Rerolled #9.

Log in or register to post comments

scor’s picture

Comment #21

scor commented 25 March 2013 at 13:38

Status:

Needs review

» Reviewed & tested by the community

thanks @dcam. this looks good.

Log in or register to post comments

yesct’s picture

Comment #22

yesct commented 26 March 2013 at 02:30

Issue tags:

removing reroll tag. we can add it back later if we need it.

Log in or register to post comments

Comment #23

David_Rothstein commented 1 April 2013 at 23:07

Status:

Reviewed & tested by the community

» Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/673aa4d

Log in or register to post comments

Comment #24

15 April 2013 at 23:10

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments