Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#8 php-1797374-8.patch3.77 KBmile23
#5 php-1797374-5.patch3.4 KBdcam
#1 php-1797374-1.patch4.08 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Status: Active » Needs review
StatusFileSize
new php-1797374-1.patch4.08 KB

Also small.

lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

I've reviewed all the changes and they all look good. RTBC.

lars toomre’s picture

lars toomre commented

I agree. +RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! Committed to 8.x, ready for 7.x backport.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new php-1797374-5.patch3.4 KB

Backported #1 to D7.

dcam’s picture

dcam commented

#5: php-1797374-5.patch queued for re-testing.

dcam’s picture

dcam commented
Issue tags: +Novice

Tagging as Novice.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
StatusFileSize
new php-1797374-8.patch3.77 KB

Found one at line 76.

lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks again - committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.