Posted by xjm

Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#11 reroll-1797372-6.patch3.32 KBchrisjlee
#6 path-1797372-6.patch3.97 KBdcam
#1 path-1797372-1.patch3.82 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Status: Active » Needs review
StatusFileSize
new path-1797372-1.patch3.82 KB

Itty-bitty.

lars toomre’s picture

lars toomre commented
Status: Needs review » Reviewed & tested by the community

I checked that this patch covers all of the needed t() removals and it does. It is also correct throughout. Hence, with the bot green, this is RTBC!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: Unassigned » jhodgdon
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Another nice small one. Thanks! Committed to 8.x.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new path-1797372-6.patch3.97 KB

Backported #1 to D7.

dcam’s picture

dcam commented

#6: path-1797372-6.patch queued for re-testing.

dcam’s picture

dcam commented
Issue tags: +Novice

Tagging as Novice.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: -Novice, -Needs backport to D7

#6: path-1797372-6.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Needs backport to D7

The last submitted patch, path-1797372-6.patch, failed testing.

chrisjlee’s picture

chrisjlee commented
Status: Needs work » Needs review
StatusFileSize
new reroll-1797372-6.patch3.32 KB

reroll

lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

Two of the changes in #6 had been removed since then - #11 fixes those that remain. RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks all! Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Removing myself from the author field so I can unfollow. --xjm