Files: 
CommentFileSizeAuthor
#9 remove_t_from_openid_testsD7-1797370-9.patch29.95 KBlazysoundsystem
PASSED: [[SimpleTest]]: [MySQL] 39,553 pass(es).
[ View ]
#9 openid_tests_interdiff.txt596 byteslazysoundsystem
#7 remove_t_from_openid_testsD7-1797370-7.patch29.52 KBlazysoundsystem
PASSED: [[SimpleTest]]: [MySQL] 39,407 pass(es).
[ View ]
#1 openid-1797370-1.patch34.2 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 41,699 pass(es).
[ View ]

Comments

xjm’s picture

Assigned:xjm» Unassigned
Status:Active» Needs review
StatusFileSize
new34.2 KB
PASSED: [[SimpleTest]]: [MySQL] 41,699 pass(es).
[ View ]
lazysoundsystem’s picture

Status:Needs review» Reviewed & tested by the community

I've reviewed all the changes and they all look good. RTBC.

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x.

jhodgdon’s picture

Version:8.x-dev» 7.x-dev
Status:Fixed» Patch (to be ported)

This needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?

lazysoundsystem’s picture

Version:7.x-dev» 8.x-dev
Status:Patch (to be ported)» Fixed

I've checked and can confirm that all the t() functions for messages have been removed from this for 8.x

jhodgdon’s picture

Version:8.x-dev» 7.x-dev
Status:Fixed» Patch (to be ported)

OK, we still need to backport to 7.x then. We only want to move back to 8.x if there is still something to be fixed there, and it sounds like there isn't (thanks for checking!).

lazysoundsystem’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new29.52 KB
PASSED: [[SimpleTest]]: [MySQL] 39,407 pass(es).
[ View ]

Didn't mean to change the version number, sorry about that. Anyway, here it is, for D7.

dcam’s picture

Status:Needs review» Needs work

One assert message got missed on line 294 of openid.test. @lazysoundsystem if you can make that change then I'll re-test and we can get this committed.

lazysoundsystem’s picture

Status:Needs work» Needs review
StatusFileSize
new596 bytes
new29.95 KB
PASSED: [[SimpleTest]]: [MySQL] 39,553 pass(es).
[ View ]

Thanks @dcam, the overlooked t() from #8 is gone now.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

Thanks @lazysoundsystem!

I applied #9 and didn't notice any additional t()'s for removal. The patch looks good to me.

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks! This patch has been committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.