Files: 
CommentFileSizeAuthor
#13 1797328-13-t-image.patch50.82 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 40,365 pass(es). View
#9 image-1797328-9.patch51.02 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch image-1797328-9.patch. Unable to apply patch. See the log in the details link for more information. View
#6 image-1797328-6.patch50.76 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch image-1797328-6.patch. Unable to apply patch. See the log in the details link for more information. View
#2 image-1797328-2.patch38.57 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 41,697 pass(es). View

Comments

xjm’s picture

Title: Remove t() from assertion messages in tests for the help module » Remove t() from assertion messages in tests for the image module
Component: help.module » image.module

Guess I accidentally swapped two issues.

xjm’s picture

Assigned: xjm » Unassigned
Status: Active » Needs review
FileSize
38.57 KB
PASSED: [[SimpleTest]]: [MySQL] 41,697 pass(es). View
Lars Toomre’s picture

Status: Needs review » Reviewed & tested by the community

It helps to review issues in detail after some good sleep!! I have reviewed this patch in detail and can confirm that each of these changes to test t() assertion messages are correct. This patch includes some format_string() changes as well which are also correct.

With the bot also being happy, this is RTBC!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

jhodgdon’s picture

Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

This needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?

dcam’s picture

Status: Patch (to be ported) » Needs review
FileSize
50.76 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch image-1797328-6.patch. Unable to apply patch. See the log in the details link for more information. View

Backported #2 to D7.

dcam’s picture

Issue tags: -needs backport to D7

#6: image-1797328-6.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +needs backport to D7

The last submitted patch, image-1797328-6.patch, failed testing.

dcam’s picture

Status: Needs work » Needs review
FileSize
51.02 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch image-1797328-9.patch. Unable to apply patch. See the log in the details link for more information. View

Rerolled #6.

dcam’s picture

Issue tags: +Novice

Tagging as Novice.

izus’s picture

Issue tags: -Novice, -needs backport to D7

#9: image-1797328-9.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +needs backport to D7

The last submitted patch, image-1797328-9.patch, failed testing.

dcam’s picture

Status: Needs work » Needs review
FileSize
50.82 KB
PASSED: [[SimpleTest]]: [MySQL] 40,365 pass(es). View

Rerolled #9.

izus’s picture

Status: Needs review » Reviewed & tested by the community

hi,
the patch looks good :)
thanks

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for all the retests, rerolls, and reviews! dcam/izus: you are on fire!
Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.