Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Posted by xjm
Part of meta #500866: [META] remove t() from assert message.
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.txt | 540 bytes | dcam |
#10 | 1797286-10-forum-t.patch | 13.28 KB | dcam |
#6 | 1797286-6-forum-t.patch | 13.28 KB | dcam |
#1 | forum-1797286-1.patch | 13.74 KB | xjm |
Comments
Comment #1
xjmI had to reformat one of the
format_string()
replacement lines here because it had so many parens that I couldn't read it myself.Comment #2
Lars Toomre CreditAttribution: Lars Toomre commentedI have reviewed each of the changes in this patch and each one of the removal/conversion of t() from test asserts is correct.
With the bot being green, this issue is RTBC!
Comment #3
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #5
David_Rothstein CreditAttribution: David_Rothstein commentedThis never made it into Drupal 7.
Comment #6
dcam CreditAttribution: dcam commentedBackported #1 to D7.
Comment #7
jhodgdon#6: 1797286-6-forum-t.patch queued for re-testing.
Comment #8
lazysoundsystem CreditAttribution: lazysoundsystem commentedNo need for parentheses here, otherwise it's all fine.
Comment #9
jhodgdonComment #10
dcam CreditAttribution: dcam commentedFixed the issue pointed out in #8.
Comment #11
lazysoundsystem CreditAttribution: lazysoundsystem commentedThanks @dcam, this too is good to go. RTBC.
Comment #12
jhodgdonThanks all! This has been committed to 7.x. Only about 4 more to go!
Comment #13.0
(not verified) CreditAttribution: commentedRemoving myself from the author field so I can unfollow. --xjm