Files: 
CommentFileSizeAuthor
#13 1797272-13-t-filter.patch74 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 40,379 pass(es).
[ View ]
#8 1797272-8-t-filter.patch74.03 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797272-8-t-filter.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 1797272-3-t-filter.patch76.83 KBLars Toomre
PASSED: [[SimpleTest]]: [MySQL] 41,894 pass(es).
[ View ]
#1 filter-1797272-1.patch65 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 41,701 pass(es).
[ View ]

Comments

xjm’s picture

Assigned:xjm» Unassigned
Status:Active» Needs review
StatusFileSize
new65 KB
PASSED: [[SimpleTest]]: [MySQL] 41,701 pass(es).
[ View ]

Bigger. No format_string().

xjm’s picture

Title:Remove t() from asserts messages in tests for the field module» Remove t() from asserts messages in tests for the filter module
Lars Toomre’s picture

StatusFileSize
new76.83 KB
PASSED: [[SimpleTest]]: [MySQL] 41,894 pass(es).
[ View ]

This patch takes the patch from #1 and adds coveragefor missing coverage. This now has 212 changes across 8 Test files. According to my local install, there are no other t() changes needed for this module.

Let's see what the bot thinks of all of these cumulative changes.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

I tested #3. I didn't find any more t()'s around Filter module test assert messages. The patch looks ok to me.

Lars Toomre’s picture

Thanks for the review @dcam!

webchick’s picture

Assigned:Unassigned» jhodgdon

Tum te tum...

jhodgdon’s picture

Version:8.x-dev» 7.x-dev
Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Patch (to be ported)

Thanks! 212 changes committed to 8.x... time to port!

dcam’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new74.03 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797272-8-t-filter.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Backported #3 to D7.

dcam’s picture

#8: 1797272-8-t-filter.patch queued for re-testing.

dcam’s picture

Issue tags:+Novice

Tagging as Novice.

izus’s picture

#8: 1797272-8-t-filter.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +needs backport to D7

The last submitted patch, 1797272-8-t-filter.patch, failed testing.

dcam’s picture

Status:Needs work» Needs review
StatusFileSize
new74 KB
PASSED: [[SimpleTest]]: [MySQL] 40,379 pass(es).
[ View ]

Rerolled #8.

izus’s picture

Status:Needs review» Reviewed & tested by the community

Hi,
the patch looks good for me
Thanks

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks all! Committed to 7.x -- another one closed. :)

Automatically closed -- issue fixed for 2 weeks with no activity.