Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
dblog.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Sep 2012 at 21:36 UTC
Updated:
4 Jan 2014 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
xjmAnother tiny one.
git diff --color-wordsComment #2
lars toomre commentedAgain I check each of these message sting changes and all are appropriate. Let's wait for the bot to come back green, but these changes look good to go.
Comment #3
lars toomre commentedThis is ready to go!! RBTC
Comment #4
xjmComment #5
jhodgdonThis one's in! Time for 7.x.
Comment #6
jhodgdonoops.
Comment #7
lazysoundsystem commentedHere's for 7.x
Comment #9
dcam commentedBackported #1 to D7.
Edit: Sorry for the crosspost. I wouldn't have written another D7 patch had I noticed lazysoundsystem's #7.
Comment #11
jhodgdonThis patch (#9) is failing with this error:
That's a typo -- format_text() [does not exist] vs. format_string() [correct function] :
#7 has a different error (database query error)... seems like #9 will be easier to fix.
Comment #12
dcam commentedFixed the function error in #9.
Comment #13
dcam commented#12: dblog-1797242-12.patch queued for re-testing.
Comment #15
dcam commentedRerolled #12.
Comment #16
dcam commentedTagging as Novice.
Comment #17
izus commented#15: dblog-1797242-15.patch queued for re-testing.
Comment #18
izus commentedhi,
the patch seems good
Thanks
Comment #19
dcam commentedThanks for the review, izus!
Comment #20
jhodgdonThanks all! Committed to 7.x and this one is done!