Files: 
CommentFileSizeAuthor
#15 dblog-1797242-15.patch11.72 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 40,331 pass(es).
[ View ]
#12 dblog-1797242-12.patch11.49 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch dblog-1797242-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#9 dblog-1797242-7.patch11.49 KBdcam
FAILED: [[SimpleTest]]: [MySQL] 39,088 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#7 remove_t_from_dblog_tests_7.x-1797242-7.patch11.48 KBlazysoundsystem
FAILED: [[SimpleTest]]: [MySQL] 39,456 pass(es), 0 fail(s), and 1 exception(s).
[ View ]
#1 dblog-1797242-1.patch11.12 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 41,698 pass(es).
[ View ]

Comments

xjm’s picture

Assigned:xjm» Unassigned
Status:Active» Needs review
StatusFileSize
new11.12 KB
PASSED: [[SimpleTest]]: [MySQL] 41,698 pass(es).
[ View ]

Another tiny one.

git diff --color-words

Lars Toomre’s picture

Again I check each of these message sting changes and all are appropriate. Let's wait for the bot to come back green, but these changes look good to go.

Lars Toomre’s picture

Status:Needs review» Reviewed & tested by the community

This is ready to go!! RBTC

xjm’s picture

Assigned:Unassigned» jhodgdon
jhodgdon’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

This one's in! Time for 7.x.

jhodgdon’s picture

Assigned:jhodgdon» Unassigned

oops.

lazysoundsystem’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new11.48 KB
FAILED: [[SimpleTest]]: [MySQL] 39,456 pass(es), 0 fail(s), and 1 exception(s).
[ View ]

Here's for 7.x

Status:Needs review» Needs work

The last submitted patch, remove_t_from_dblog_tests_7.x-1797242-7.patch, failed testing.

dcam’s picture

Status:Needs work» Needs review
StatusFileSize
new11.49 KB
FAILED: [[SimpleTest]]: [MySQL] 39,088 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Backported #1 to D7.

Edit: Sorry for the crosspost. I wouldn't have written another D7 patch had I noticed lazysoundsystem's #7.

Status:Needs review» Needs work

The last submitted patch, dblog-1797242-7.patch, failed testing.

jhodgdon’s picture

This patch (#9) is failing with this error:

Fatal error: Call to undefined function format_text() in /var/lib/drupaltestbot/sites/default/files/checkout/modules/dblog/dblog.test on line 283

That's a typo -- format_text() [does not exist] vs. format_string() [correct function] :

@@ -280,7 +280,7 @@ class DBLogTestCase extends DrupalWebTestCase {
     $this->assertResponse(200);
     // Retrieve node object.
     $node = $this->drupalGetNodeByTitle($title);
-    $this->assertTrue($node != NULL, t('Node @title was loaded', array('@title' => $title)));
+    $this->assertTrue($node != NULL, format_text('Node @title was loaded', array('@title' => $title)));

#7 has a different error (database query error)... seems like #9 will be easier to fix.

dcam’s picture

Status:Needs work» Needs review
StatusFileSize
new11.49 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch dblog-1797242-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Fixed the function error in #9.

dcam’s picture

Issue tags:-needs backport to D7

#12: dblog-1797242-12.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+needs backport to D7

The last submitted patch, dblog-1797242-12.patch, failed testing.

dcam’s picture

Status:Needs work» Needs review
StatusFileSize
new11.72 KB
PASSED: [[SimpleTest]]: [MySQL] 40,331 pass(es).
[ View ]

Rerolled #12.

dcam’s picture

Issue tags:+Novice

Tagging as Novice.

izus’s picture

#15: dblog-1797242-15.patch queued for re-testing.

izus’s picture

Status:Needs review» Reviewed & tested by the community

hi,
the patch seems good
Thanks

dcam’s picture

Thanks for the review, izus!

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks all! Committed to 7.x and this one is done!

Automatically closed -- issue fixed for 2 weeks with no activity.