Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#3 config-1797228-2.patch3.95 KBxjm
#1 config-1797228-1.patch1.38 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Status: Active » Needs review
Issue tags: +Needs backport to D7
StatusFileSize
new config-1797228-1.patch1.38 KB

Small one (yay for modern code), so I included the few format_string() changes.

git diff --color-words

Status: Needs review » Needs work

The last submitted patch, config-1797228-1.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new config-1797228-2.patch3.95 KB

Well not THAT small. This is the correct patch.

lars toomre’s picture

lars toomre commented

Each one of those message changes are correct and appropriate. Let's wait for green to come back, but I think this is RTBC.

lars toomre’s picture

lars toomre commented
Status: Needs review » Reviewed & tested by the community

This is RTBC.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: Unassigned » jhodgdon

Thanks for the reviews!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 8.x. I guess this one doesn't get backported, and I guess it's all fixed up (including format_string ones, right?), so we're done?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned

forgot to unassign

Automatically closed -- issue fixed for 2 weeks with no activity.