Remove t() from assertion messages in node.module tests

I have reviewed each of the straight t() removals from the assert messages in the #2 patch. All are correct and appropriate. I will leave checking for completeness to the follow-up patch correcting t() to format_string() conversions.

With the bot being green, this is RTBC!

Committed the patch in #2 to 8.x. Leaving this issue open for follow-ups for t() -> format_string().

Here is an untested patch that completes the removal of t() from the node test assert messages or, if appropriate, the conversion of t() to format_string().

With this patch applied, I do not observe any more case of t() being used in node tests using grep. This patch includes the final 27 conversions in this module.

I tested #6 and found two more t()'s around assert messages in NodeRevisionsTest.php on lines 87 and 99.

I could alter the patch myself, but then then we'll have to wait for someone else to test it. @Lars Toomre, if you can make the changes then I'll be sure to come back and re-test. Then we can get this committed.

Here is a patch that includes the two items noted in #7.

I've verified that #8 removes the two t()'s found in #7. I can't find any others that were missed. The patch looks good to me. Marking as RTBC.

Tum te tum...

Thanks, that one's in! Looks like we need to port #2 + #8.

Thanks @jhodgdon for the review and commit. It is so nice to see the node Tests now complete for D8. Thanks!!

Backported #2 and #8 to D7.

#13: 1797200-13-t-node.patch queued for re-testing.

I'm not sure why #13 wasn't applying, but I re-backported #2 and #8 to try and get a good patch this time.

Let's try this again. I rolled this one on a different system. Maybe I did something to node.test on that other laptop that's causing #13 and #17 to not apply.

Backport of #2 and #8 to D7.

#19: 1797200-19-t-node.patch queued for re-testing.

I rerolled the patch in #19.

#22 had the same problem described in #19. Sorry about that.

I rerolled #17 again and changed another unneeded t(). The post-reroll change is shown in interdiff.txt.

Tagging as Novice.

Thanks! Assigning to me to commit unless someone else beats me to it.

Thanks all! This one is committed to 7.x. Another one of these closed!