Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#10 field-ui-1797170-10.patch20.09 KBdcam
#7 field-ui-1797170-7.patch20.11 KBdcam
#1 field_ui-1797170-1.patch21.44 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Assigned: xjm » Unassigned
Status: Active » Needs review
FileSize
field_ui-1797170-1.patch21.44 KB

Includes both "simple" assertions and ones that require format_string(), because there weren't very many.

You can apply locally and use git diff --color-words to review.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Title: Remove t() from assertion messages in field_ui.module » Remove t() from assertion messages in tests for field_ui.module
Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Needs review » Reviewed & tested by the community

I have reviewed each one of the message changes in this patch and all are appropriate. I did note one instance of a double quoted string that could be turned to single quoted, but that hardly is reason to re-roll this patch. Hence, with green back from the test bot, this is RTBC!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Needs backport to D7

Thanks Lars!

Tagging for backport for consistency.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Assigned: Unassigned » jhodgdon
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Version: 8.x-dev » 7.x-dev
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Patch (to be ported)

Phew! I think that's the last of them for the moment. Thanks all!

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Patch (to be ported) » Needs review
FileSize
field-ui-1797170-7.patch20.11 KB

Backported #1 to D7.

dcam’s picture

dcam CreditAttribution: dcam commented
Issue tags: -Needs backport to D7

#7: field-ui-1797170-7.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs backport to D7

The last submitted patch, field-ui-1797170-7.patch, failed testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs work » Needs review
FileSize
field-ui-1797170-10.patch20.09 KB

Rerolled #7.

dcam’s picture

dcam CreditAttribution: dcam commented
Issue tags: +Novice

Tagging as Novice.

izus’s picture

izus CreditAttribution: izus commented

#10: field-ui-1797170-10.patch queued for re-testing.

izus’s picture

izus CreditAttribution: izus commented
Status: Needs review » Reviewed & tested by the community

hi,
the patch seems ok
Thanks

dcam’s picture

dcam CreditAttribution: dcam commented

Thanks for the review, izus!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks all! Committed to 7.x and this one is taken care of.

Automatically closed -- issue fixed for 2 weeks with no activity.