Elimination of Dark Code

Marking this assigned to joachim. Feel free to unassign yourself when you're happy with this.

Recently some things with clients has meant that things have had to be a bit rushed and now there is a confusion between the code rob and andrew are working on and what is available to the party community generally. The biggest issue is that this makes certain conversations about use cases complicated. However to further add to the issue the definition of what is "dark code" is complicated as there are some things in our client's implementations that are in configuration not code (such as custom blocks) that actually make quite a big difference to how Party is used.

So this is an issue to open up a discussion on what we think currently may or may not exist in dark code and also link to issues where we are getting things out in the open.

So first without going into names of our clients I'll talk about the clients we are working on and what may be dark code:

DirectoryCharity - Erno
Seeing as this is developed by a developer outside of Common Nonsense, he only uses code he has access to.

This is a charity that uses Party but also have a publically accessible directory. They use elements of the Party dashboard and Facetted search to display the directory in a totally different theme. It shows all parties with a specific hat on and only shows a sub-set of the information about that organisation. It is currently implementing OG integration and Acquisition stuff.

As far as I can tell there is no dark code apart from maybe its novel implementation of the directory. When we get the acquisition stuff in there will be some configuration to allow users to access their own party data that may not go into party code (its UI stuff)

- They ideally want in-line editing for editing parties

EventCharity
A charity that holds summer conferences. We have 2 potential clients doing this and will take about a year to complete. At the moment they are starting with a booking system + party acquisition (And so parties will be created when tickets are booked on behalf of someone else)

College - andrew belcher
This is a college that provides a university course through distant learning. Andrew is trying to get as much of the stuff (particularly party dashboard stuff) into core properly now. Other things it has:

- "Flexiform?" a very customisable application process that saves information into datasets
- Notes and History Log - a quickly made block on the dashboard that shows a history of all changes on one tab and notes on another. I do not think we want this in party core (I think we want to do it differently)
- all information is displayed in an editable form so changes can quickly be made.

Business to Business - rlmumford and dave connerth

This is for sales teams. Contacts are assigned to a certain sales team which they can use for their work.

- Does not use party acquisition or use integration. Parties are contacts that users (staff) can access and edit for their work.
- Does not use hierarchical hats.
- Contacts are always in an organisation, enforced through the UI. You can create an organisation and then when in the organisation you can create the contacts. The UI is the "Sky" theme + custom blocks.

Party Development Demo Site
Located here:
http://partydev.commonnonsense.co.uk/admin/party

This is something that shows off the dashboard. Requires a bunch of the College stuff and
#1790148: What should we do with the Party Dashboard theme? CNS Admin
I think there is something in party core somewhere to make devel generate those demo parties?

--------
Question: Do we try and get some of the actual configuration into the party community?
In my mind, this dark code issue is something commerce have struggled with, especially with things like the Product Display/ Product issue. There are lots of things when discussing use cases that can only be seen easily by actually trying to build something yourself for a client. Commerce Kickstart v2 is solving a lot of that but they have a company dedicated to nothing but commerce and loads of venture capital.

I've got a few ideas of how to deal with this but over to you!