Do not switch on the teaser splitter for Konqueror

Subscribing, since I'm one of our few Konqueror users. :-)

Also setting to critical, as a data loss situation is never acceptable. I'm OK with just disabling the teaser splitter if we can't fix it, but data loss is a release blocker.

This is an irksome browser with few users. Let's fix these issues with the help of the killswitch. And yes, I run Kubuntu.

Well, most of the JS effects work fine. It's just the teaser splitter, I think, that is dangerously buggy.

BTW, http://drupal.org/node/176222#comment-308773 fixed it in Safari for me.

And OpenID login is broken too. (or it was when i last tested)

Yes, OpenID is broken, too. I tried to debug it when jQuery 1.2 came out, but I failed. There are some major features of jQuery that don't seem to work properly in some cases in Konqueror (like $(foo).show() was the problem with OpenID login).

I will not debate whether it's lazy or not to support Konquerer. But in regards to the actual patch - generally browser detection is discouraged. So if we can't do object detection in the specific cases I think it's wiser to just check for UNsupported browsers (Konquerer in Drupals case).

Agreed with fajerstarter.

Here is a patch that turns off the table splitter for Konqueror. Open ID was mentioned as well (should be easier to debug/fix though)?

This needs to get in and then we can deal w/ OpenID. I verified it with an amount of browsers and also by googling, there is a massive amount of articles stating that checking for KDE in the vendor string is the best way to check for Konqueror.

Thanks for the literature search ;) I took this from http://davecardwell.co.uk/javascript/jquery/plugins/jquery-browserdetect/ which in turn is based on Quirksmodes http://www.quirksmode.org/js/detect.html

I don't rule out that it's possible to do object detection here, I just don't have a good enough KDE setup to debug this. BTW, there is a usability patch for the OpenID login form, I don't expect it to fix anything, but would be interesting to have a Konquer user test it anyway: http://drupal.org/node/186658

Ok, so I actually took the time to try Drupal in Konqueror. I had no idea was that bad (guess I could have search d.o first...). Did some testing and what it boils down to is that a lot of jQuery selectors doesn't work in Konqueror, one example is the often used $("element.classname"). So collapsible fieldsets, OpenID form, etc is broken.

So, it seems that it's time to pull the plug for Konqueror and re-evaluate that after the next jQuery upgrade. This patch is quicksketch's approach but checks only for Konqueror.

When the heck did that happen? I use Drupal in Konqueror all the time, including D6-dev, and the teaser splitter is the only thing I've ever found that broke. (I haven't tested OpenID myself, though.) Collapsible fieldsets worked fine the last time I was testing D6. There must be something else going on here.

This and this both suggest that Konqueror support died with 1.1.

Ok, seem like my efforts to actually test this was out of luck then. Putting back the patch in #11 to RTBC since chx deemed it ready.

@catch: See the original jQuery 1.2.1 issue. As of then, everything worked in Konqueror except for the teaser splitter. If it doesn't now, then something since then broke it and needs to be fixed.

doh! I even posted on that issue :(

Crell, have you tested the patch in #11? It does what you proposed in #1 (turning off just the teaser splitter), which seems like the best approach after all. chx tested it succesfully and set it RTBC.

I just tested #11 in Konqueror 3.5.6, and it successfully disabled the teaser splitter. Other javascript functionality seems unaffected, and works normally. (And it's such a small patch I don't know how it could be.) RTBC.

I haven't tested OpenID. That should be a separate issue.

Thanks, committed #11.

I adressed the OpenID problem here: http://drupal.org/node/186658#comment-329139