For distribution authors, as well as probably module authors, it's really handy to know what variable_get() names changed to in CMI. I picture a table of old vs. new variable names to make conversions of variable_get() calls easy.

This is postponed on #1775842: [meta] Convert all variables to state and/or config systems, however, so no sense in butting up against thresholds.

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Created a node for this at http://drupal.org/node/1785368

catch’s picture

catch
he/him
Primary language English
commented
Priority: Major » Normal

Postponed issues are counted in thresholds now, and there's only a couple of variables left.

This feels like a 'nice to have' to me so downgrading from major.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I think it might be useful for someone to put some explanation into this change notice node as to what it means and how to use it.

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Active

Meant to move this to active.

catch’s picture

catch
he/him
Primary language English
commented

https://api.drupal.org/api/drupal/core%21includes%21update.inc/function/... has all the changes - I also wonder whether that + an explanation might be enough.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Needs review

I have just edited https://drupal.org/node/1785368 as a first pass at doing what is suggested in comment #5. Should we leave it at that? I am inclined to agree with catch that building and maintaining a list of all the variables may not be necessary and it's also definitely a lot of work (though perhaps a good Novice project, now that this explanation is right there on how to do it)?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Bump. I think maybe this is done? Tentatively marking RTBC to attract attention. I'll mark it fixed if no one objects in the next few days.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Agree with the priority downgrade.

And, hm. That's definitely not ideal, since it requires hand-clicking on up to (currently) 46 functions in order to hopefully land on one that changes the out-dated variable in question that you have in your install profile so you know what it switched to.

In such a situation, what you want to search for is a string like 'site_frontpage'. But you'll get no results found on https://api.drupal.org/. You will find it if you click on https://api.drupal.org/api/drupal/core!modules!system!system.install/fun..., but I'm not sure how an average person would've arbitrarily found that in that gigantic list.

Incidentally, this variable in particular has a dedicated change notice at https://drupal.org/node/1668806 already, so it will come up in searches on change notices for "site_frontpage". Maybe the true way to resolve this is just to create similar dedicated change notices for "frequently accessed variables" like that. I agree one massive table with all of them is unlikely to ever get done.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Agreed with it being good to be able to search change notices to find the variable names.

Currently, the best/only way for someone to search for these would be to download 8.x and use grep, and IDE, or another method to search the code base. I have added that to the instructions in case people don't think of that; you're right, api.drupal.org won't help in this regard.

I'm not sure which variables would qualify as "frequently accessed" to think of which should be added here.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes

What's left to be done here?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Personally I do not think it is reasonable to expect a complete list of variables to be on that page and I am in favor of marking this issue as fixed.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

I am just going to mark this very old issue as fixed at this point. I don't think we can/should do more.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.