Support custom child list types in theme_item_list() [#1785310]

Item list type is inherited from parent by all children. Lists of one type, i.e. ul cannot be a child of an ol list type.

Allow item_list children to define their own type attribute, in order to produce i.e. ol > li > ul.

- template_preprocess_item_list() from #1800726: Convert theme_item_list to item-list.twig applied to core 8.x.
- Documentation in template files.

- None.

- type attribute support in item_list children.

Comment	File	Size	Author
	item-list.patch	2.29 KB	droplet

Comments

steveoliver commented 15 October 2012 at 16:30

Status:

Needs review

» Needs work

steveoliver commented 15 October 2012 at 16:34

Issue summary:

Updated issue summary.

steveoliver commented 15 October 2012 at 18:27

Status:

Needs work

» Reviewed & tested by the community

Looks good to me. Would like to see this in core.

he/him

English

commented 17 October 2012 at 21:27

Title:	Add 'type' support to theme_item_list nested child items	» Change notice: Add 'type' support to theme_item_list nested child items
Category:	feature	» task
Priority:	Normal	» Critical
Status:	Reviewed & tested by the community	» Active

Looks reasonable to me, not really a feature either, test changes look fine too. Committed/pushed to 8.x. Needs a change notice for the API addition.

fabianx commented 18 October 2012 at 05:37

Title:	Change notice: Add 'type' support to theme_item_list nested child items	» Add 'type' support to theme_item_list nested child items
Category:	task	» feature
Priority:	Critical	» Normal
Status:	Active	» Fixed