The link generated has a non urlencoded ampersand, which results in invalid xhtml.

google_fonts_api.module

line 92:
$url = $base . implode('|', $families) . '&subset=' . implode(',', $subsets);
change to:
$url = $base . implode('|', $families) . '&subset=' . implode(',', $subsets);

CommentFileSizeAuthor
#2 fontyourface-Link_to_Google_fonts_results_in_invalid_xhtml-1784734-2.patch1006 bytesDrave Robber

Comments

Drave Robber’s picture

Drave Robber commented
Version: 6.x-2.10 » 6.x-2.x-dev
Assigned: Unassigned » Drave Robber
Status: Active » Needs work

Urlencoded ampersand seems to work. However, Google has its own notion of what is valid and what is not. With some Google APIs (e.g. 'old' Image Charts API), one needs to encode _parts_ of the URL. Hence, this will need some testing.

Drave Robber’s picture

Drave Robber commented
Assigned: Drave Robber » Unassigned
Status: Needs work » Needs review
StatusFileSize
new fontyourface-Link_to_Google_fonts_results_in_invalid_xhtml-1784734-2.patch1006 bytes

Proposed change does not break anything and makes the markup pass http://validator.w3.org/check

Patch attached.

(On a side note, this issue does not affect 7.x-2.x)

castawaybcn’s picture

castawaybcn commented

Patch worked perfectly for me. Remember to clean your caches though.

Thanks a lot for this.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Looks good!

Drave Robber’s picture

Drave Robber commented

Committed.

(credited to madlee as the initial report was clear enough as to what needs to be done, even if there was no patch)

Drave Robber’s picture

Drave Robber commented
Status: Reviewed & tested by the community » Fixed

(fixed)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

typo