If using the patches in #1356276: Make install profiles inheritable the libraries module is not aware of parent profiles which may have libraries directories to be searched.

Proposed resolution

Rely on adjustment to drupal_system_listing_profile from #1356276: Make install profiles inheritable to add paths to the directories searched so all relevant profiles are considered.

Remaining tasks

None known, this issue is to make a patch available if needed.

User interface changes


API changes

libraries_get_libraries function may now search more directories than previously done.

#5 inherited-profiles-1783598-5.patch1.92 KBdagomar
#4 libraries-profile_inheritance-1783598-4.patch635 bytespmelab
#2 libraries-profile_inheritance-1783598-2.patch680 bytestekante
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
#1 libraries-profile_inheritance-1356276-1.patch680 bytestekante
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View


tekante’s picture

new680 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Patch is attached. Will mark this as needs review just so the maintainer can take a quick look but I suspect that since this is a patch dependent on a patch this should likely be closed as a won't fix or as designed (pending real support of inherited profiles in core).

tekante’s picture

Status:Active» Needs review
new680 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Correction of patch naming and status change. Patch is identical but improper name on previous version would make it hard to track back to this issue from a make file.

tstoeckler’s picture

Version:7.x-1.0» 8.x-3.x-dev
Status:Needs review» Postponed

Patch looks good, but I'm setting to postponed until the core issue gets in.

pmelab’s picture

Version:8.x-3.x-dev» 7.x-2.1
Assigned:tekante» pmelab
new635 bytes

Recreated the patch for libraries version 2.1

dagomar’s picture

Issue summary:View changes
new1.92 KB

The patch in #4 goes with patch #25 here: #1356276-25: Make install profiles inheritable. However, after that the function drupal_system_listing_profile was removed from the patches. So, #4 will now result in a WSOD (call to undefined function).

To make matters more complicated, the referred issue was split up to allow D7 and D8 development to live independently from one another. So, I have created a new patch that takes into account the latest available patch (surprise, also by me) in the newly created issue here: #2067229-41: Allow install profiles to declare base profiles for Drupal 7

The patch basically lifts the drupal_system_listing_profile from the old patch and adds it to the libraries module as libraries_system_listing_profile.

tstoeckler’s picture

Status:Postponed» Closed (duplicate)

Marking duplicate of #2081579: Base profile support