I think this module is great and checked it out. It works well enough, but the red color is a bit wierd when placed over a message that isn't an error. It would be great if the dismiss button mirrored the color of the message box as provided by system.messages.css in Drupal core.

CommentFileSizeAuthor
#2 1775528-2-dismiss-colors.patch468 bytesrupl
#1 1775528-support-different-message-colors-dismiss.patch438 bytespopulist

Comments

populist’s picture

populist commented
Status: Active » Needs review
StatusFileSize
new 1775528-support-different-message-colors-dismiss.patch438 bytes

Here is a patch that helps to provide better coloring of the messages.

rupl’s picture

rupl
he/him
Primary language English
commented
StatusFileSize
new 1775528-2-dismiss-colors.patch468 bytes

Nice idea! It does improve the non-error messages. Here's a slightly different patch with black for status and warning. Like?

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Needs review » Fixed

No complaints means it's perfect ;)

Committed along with some other minor visual tweaks: http://drupalcode.org/project/dismiss.git/commitdiff/8817ee5

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.