The Drupal Ladder install profile relies on Node access user reference. nodeaccess_userreference and entityreference are both listed in the install profile's .info file, but I think there's a race condition or something: nodeaccess_userreference_requirements() won't let the install continue because it checks module_exists('entityreference'), and entityreference is (I guess?) not yet enabled at that point in the installation process.

I'm really not sure how to handle this. That function could check the $phase argument, but that will be install during the installation process AND when the module is installed from the module list, after the site is up and running, so that's not right either.

Attaching a screenshot of the error that prevents installation.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

BrockBoland’s picture

FileSize
510 bytes

NOT A REAL PATCH

I'm only posting this here for use in the make file of an install profile to make my life easier for a little bit.

btopro’s picture

real patch to fix this problem.

btopro’s picture

Sorry, this is the correct patch for this problem

btopro’s picture

Status: Active » Needs review
BrockBoland’s picture

Status: Needs review » Reviewed & tested by the community

That did it! Install process worked smoothly. On another site, I enabled this module without References or Entity Reference, and it enabled fine but showed the "One or more problems were detected with your Drupal installation. Check the status report for more information." error message, with the correct warning in the status report.

Looks good to me!

btopro’s picture

Becomes conjecture if the maintainer thinks this is intended behavior. You could validate that it's during the install routine but most modules don't bar activation unless there's going to be a mega-glitch without a project turned on (especially since this can't request one of two optional projects to work). As I don't think this is the case (total failure) I'd recommend the current solution.

BrockBoland’s picture

Becomes conjecture if the maintainer thinks this is intended behavior.

True, but that's the case of a patch on any issue where the maintainer isn't involved in the conversation, so we'll see what happens.

steveray’s picture

Jumping in late here, but want to confirm that the patch at #3 cures the error message when Node Access User Reference is enabled as a Features dependency.

As for the module maintainer, it seems he's not working on this anymore.

Tschet’s picture

Issue summary: View changes

Patch #3 still works if anyone has this issue.

danielb’s picture

Status: Reviewed & tested by the community » Fixed

Yeah that's fine

  • danielb committed b820e77 on 7.x-3.x authored by btopro
    Issue #1774488 by btopro, BrockBoland: Requirements check kills install...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.