Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Patch below adds a destination for domain_alias module
Comment | File | Size | Author |
---|---|---|---|
#8 | 1774114-add_support_for_aliases_migration-8.patch | 7.89 KB | ParisLiakos |
#4 | 1774114-add_support_for_aliases_migration-4.patch | 7.94 KB | ParisLiakos |
#1 | 1774114-add_support_for_aliases_migration-1.patch | 7.94 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedPatch attached
Comment #2
agentrickardI'm tempted to suggest we spin off Migration support. If the code keeps expanding to cover all the modules, I can't keep up with it.
Nice patch, though. What's the use-case for this?
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedHmm no need to maintain them, let them leave in there, community will do its job. Not to mention that they are a separate part, that does not affect module functionality. Any ways if you still dont like it there is always the migrate_extras module;)
I am also preparing a patch for domain_menu_block now, will be in its issue queue shortly.
I am migrating an old custom cms with about 300 domains and 1,2k aliases...
and i was so lucky that you recently added migrate support, thanks:D
Comment #4
ParisLiakos CreditAttribution: ParisLiakos commentedFixing wrong variable name when updating counters
Comment #5
agentrickardLooks pretty good. I don't know how hard support will be. Migrate is fairly stable, so once this works we should be able to add it without too much hassle.
I don't know that the migrate_extras team would want to support this either, since testing DA can be a challenge.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedwell tbh, i doubt you will have any bug reports, or it waste your time.
like you said, migrate is very stable, your database fields that need mapping to it dont change everyday and people that use migrate are coders that know their way around, so no support requests as well.
And thats true DA is a challenge:)
Anyways it is your decision!
If you decide you dont want it, i will transfer this patch to migrate extras queue and test my luck there.
Cheers
Comment #7
agentrickardI'm going to release the other migrate code first, and then we'' let other people test this one out and see.
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedreroll for the .info changes
Comment #9
agentrickardI wonder if we can key this to machine_name instead of domain_id, or if that doesn't work for most use-cases?
Is it possible at least to use machine_name as a lookup key?
Comment #10
ParisLiakos CreditAttribution: ParisLiakos commentedyes, it would be possible to take the machine_name, load the domain and extract the id to store in the table..hmm that would make more sense, cause you could then map imported domains easier..right now i have to do:
in my domain alias migration..
+1, patch will follow some day
Comment #11
agentrickardI would think we need to support both lookup methods, because people might have source data in either format. Though if the domain_id is a reference to a previous import, that is less difficult.