Call time Pass by reference was deprecated in PHP 5.3.0 and removed altogether from PHP 5.4.0. The patch for this issue has resided in the -dev release for >1 year but beta1 still exhibits the problem... warnings for folks using PHP 5.3.x, and blowing up for folks on PHP 5.4.x and beyond.
---
In PHP 5.3 if Donation form enabled in the checkout pane, then we can see next error:

Deprecated function: Call-time pass-by-reference has been deprecated inmodule_load_include() (line 329 of /var/www/commerce.loc/includes/module.inc).

This error caused in commerce_donate/includes/commerce_donate.checkout_pane.inc file.

Patch attached.

CommentFileSizeAuthor
commerce_donate-fix_deprecated_message.patch855 bytesinternetdevels

Comments

stella’s picture

stella commented
Status: Needs review » Fixed

Thanks, fixed in the latest dev version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

emjayess’s picture

emjayess commented
Issue summary: View changes
Status: Closed (fixed) » Needs review

It's a problem when an issue more than a year old still afflicts those trying to implement this, because the patch to fix it sits forever in the -dev release and never even gets promoted to (in the case of this module) the beta release.

Call time pass by reference was deprecated in PHP 5.3.0 and removed from 5.4.0.

emjayess’s picture

emjayess commented
Title: Problem with PHP 5.3. » Remove Call-time Pass By Reference
Issue summary: View changes
emjayess’s picture

emjayess commented
Status: Needs review » Reviewed & tested by the community

just updating to RTBC :)

kenahoo’s picture

kenahoo commented

What's the status of this? 7.x-1.0-beta1 seems to still have the problem.

theamoeba’s picture

theamoeba commented

+1

lsolesen’s picture

lsolesen commented
Status: Reviewed & tested by the community » Closed (fixed)

This is fixed in latest dev.

emjayess’s picture

emjayess commented

This was fixed in the latest dev two+ years ago. The objective to resurrecting the issue and marking it RTBC was to further encourage a newly-rolled release (so people don't have to download the old release, encounter the problem, hunt through closed issues for a patch or to determine whether to use a -dev release).

petu’s picture

petu commented
Status: Closed (fixed) » Needs work

Subscribing to #9.
Could you please move the changes to beta1?

stella’s picture

stella commented
Status: Needs work » Closed (fixed)

Changing this back to closed (fixed) as the issue is fixed. There is already another ticket asking for a release to be made, so keeping this thread open doesn't contribute anything extra.

glass.dimly’s picture

glass.dimly commented
Priority: Normal » Critical

I'm marking this bug as critical but leaving this issue closed because it blocks the editing of the donation amounts presented at checkout.