Support other entities than nodes

Could the maintainer please make a statement here?

Ok, I guess I will give it a shot in a few weeks.

I was not able to try this. Maybe I will get a budget for this in the next few months...

Looking at this once again, I realized that the module uses the taxonomy_index table, which is an index of the references between nodes and taxonomy terms. Either we need to introduce a table that holds data for all entity types or we need to run much more complex queries...

Has anyone made progress on this?

I just realized that there is this module that provides an index for any entity type: https://www.drupal.org/project/taxonomy_entity_index

Here is the core issue regarding this: https://www.drupal.org/project/drupal/issues/1040786

I worked on this for a bit. I managed to get the dynamic queries right, except for the one in SimilarTermsArgument.

Changing this

$this->query->addTable('taxonomy_index', NULL, NULL, 'similarterms_taxonomy_index');

to this

$this->query->addTable('taxonomy_entity_index', NULL, NULL, 'similarterms_taxonomy_index');

Causes the following error:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'similarterms_taxonomy_index.tid' in 'where clause': SELECT "commerce_product_field_data"."langcode" AS "commerce_product_field_data_langcode", COUNT(commerce_product.product_id) AS "commerce_product_product_id", MIN(commerce_product_field_data.product_id) AS "product_id" FROM {commerce_product_field_data} "commerce_product_field_data" INNER JOIN {commerce_product} "commerce_product" ON commerce_product_field_data.product_id = commerce_product.product_id WHERE (("similarterms_taxonomy_index"."tid" IN (:db_condition_placeholder_0, :db_condition_placeholder_1, :db_condition_placeholder_2)) AND ("similarterms_taxonomy_index"."entity_type" IN (:db_condition_placeholder_3)) AND ("commerce_product"."product_id" NOT IN (:db_condition_placeholder_4))) AND ("commerce_product_field_data"."status" = :db_condition_placeholder_5) GROUP BY commerce_product_field_data.product_id, commerce_product_field_data_langcode ORDER BY "commerce_product_product_id" DESC LIMIT 11 OFFSET 0; Array ( [:db_condition_placeholder_0] => 22 [:db_condition_placeholder_1] => 28 [:db_condition_placeholder_2] => 29 [:db_condition_placeholder_3] => commerce_product [:db_condition_placeholder_4] => 2716 [:db_condition_placeholder_5] => 1 )

There seems t be a missing relationship between the sql tables and therefore a join is missing from the query.

I also tried to use a left join, but somehow without success:

$this->query->leftJoin('taxonomy_entity_index', 'ti', 'ti.entity_id = :entity_id AND ti.entity_type = :entity_type AND ti.tid = :tid', [
  ':entity_id' => $this->value,
  ':entity_type' => $entity_type,
  ':tid' => $this->tids,
]);

Does anyone know how to solve this?

Ok, i got this working with my patch in #3222950: Provide views join on BASE_TABLE_field_data!

Cleaned up my patch a bit in the merge request.

Ok, here is a re-roll.