Create a node with a title that contains a '. Translate it using Google. The title of the translation is saved with a html encoded '.

CommentFileSizeAuthor
#9 incorrect_encoding-1758308-9.patch2.94 KBthenchev
#7 tr_revisions.png70.42 KBthenchev
#3 tmgmt_google-decode_translations-1758308.patch613 byteszhuber

Comments

zhuber’s picture

zhuber commented
Assigned: blueminds » Unassigned
Status: Active » Closed (works as designed)

I don't think this needs to be fixed actually.

I've tested this out on my own and found out that it only maintains the html encoding when the apostrophe cannot be translated.

For example:
"John's node example" translates to "Ejemplo nodo John"

The issue happens when google cannot translate the apostrophe, with something like this:
"John has a node!'." translates to "John tiene un nodo! '."

This could be potentially fixed, but for now it's best practice to provide translatable content. Beyond that, you can and should manually edit the translated content if it isn't translated the way that you want.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Right, it's fine if it's stays there. But it shouldn't be html encoded because that results in double encoding?

zhuber’s picture

zhuber commented
Assigned: Unassigned » zhuber
Status: Closed (works as designed) » Needs review
StatusFileSize
new tmgmt_google-decode_translations-1758308.patch613 bytes

I think I've fixed it, although I don't know if this will have implications with users who try to translate chunks of html (from WYSIWYGs or open html fields).

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Testbot bump. A test would be good to have here...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Priority: Normal » Major
Issue summary: View changes

Promoting, this is still a problem.

thenchev’s picture

thenchev commented
Assigned: zhuber » thenchev

Start looking into this.

thenchev’s picture

thenchev commented
StatusFileSize
new tr_revisions.png70.42 KB

For me, and mbovan tested it also, the google translator returns the correct result. The problem i see is in the revisions.

thenchev’s picture

thenchev commented

Sorry, looks like the title is affected. Missed that

thenchev’s picture

thenchev commented
StatusFileSize
new incorrect_encoding-1758308-9.patch2.94 KB

i suppose this should be reflected on the microsoft translator?

  • Berdir committed d374943 on 8.x-1.x authored by Denchev 
    Issue #1758308 by Denchev, zhuber: Incorrect encoding
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Yes, this works well now. Committed, back to 7.x