Currently the module fetches all images with absolute paths starting with http. But any images whose paths begin with https are not fetched

This was particularly noticed when some of the images copied from Facebook into the CK editor were not fetched (as FB cdn images had urls starting with https)

CommentFileSizeAuthor
#3 markdown_support_and_https_fix_and_compatibility_and_prevent_overwrite_1757758-3.patch2.5 KBdustise
#2 get_image-fetch-https-images-1757758-2.patch529 bytessaitanay
#1 get_image-fetch-https-images-1757758-1.patch4.75 KBsaitanay

Comments

saitanay’s picture

saitanay commented
Status: Active » Needs review
StatusFileSize
new get_image-fetch-https-images-1757758-1.patch4.75 KB

Attached is the patch,. the patch seems to be messed up because of the encoding as there is chinese language in the module comments, which my current editor settings were not supporting,.

Anyways, the only change is in the get_image.module file @ line 77

Replace
if (strpos($mat[2], $GLOBALS['base_url']) !== false || strpos($mat[2], 'http://') === false) {
with
if (strpos($mat[2], $GLOBALS['base_url']) !== false || (strpos($mat[2], 'http://') === false && strpos($mat[2], 'https://') === false)) {

Best
Tanay

saitanay’s picture

saitanay commented
StatusFileSize
new get_image-fetch-https-images-1757758-2.patch529 bytes

cleaner patch

dustise’s picture

dustise commented
Issue summary: View changes
StatusFileSize
new markdown_support_and_https_fix_and_compatibility_and_prevent_overwrite_1757758-3.patch2.5 KB

markdown support
https fix
compatibility
prevent overwrite