@return unknown_type should be @return mixed

Hey TravisCarden,
Thank you for your patch. I have reviewed them.

function ajax_forms_test_menu() {
is an implemetation of a hook. The params and return values should not be included. See: http://drupal.org/node/1354#hookimpl

/**
 * Form to display the Ajax Commands.
 * @param $form
 * @param $form_state
 * @return undefined
 */
function ajax_forms_test_ajax_commands_form($form, &$form_state) {

This function defines a form, right? The return value is an array isn't it?

I created a new patch.

Regards,
Thomas

Thanks both for your patches.
Bußmeyer is right, implementations of a hook don't include the params and return values.

Form generating functions don't, either (well, not for $form and $form_state or the return value), so we can have just:

/**
 * Form to display the Ajax Commands.
 */
function ajax_forms_test_ajax_commands_form($form, &$form_state) {

According to http://drupal.org/node/1354#forms, you can also add @ingroup forms, which groups all forms into the Form Builder topic on api.drupal.org.

So… almost there :-)

From /core/modules

grep -r ingroup . | grep test
./simpletest/simpletest.pages.inc: * @ingroup themeable
./simpletest/simpletest.pages.inc: * @ingroup themeable
./simpletest/simpletest.pages.inc: * @ingroup forms
./system/tests/modules/form_test/form_test.module: * @ingroup forms
./system/tests/modules/form_test/form_test.module: * @ingroup forms
./system/tests/modules/form_test/form_test.module: * @ingroup forms
./system/tests/modules/form_test/form_test.module: * @ingroup forms
./system/tests/modules/form_test/form_test.module: * @ingroup forms
./file/tests/file_module_test.module: * @ingroup forms

Seems a bit inconsistent re: @ingroup. Re-rolled without the change.

Doh. Test it!

Interesting observation about use of @ingroup, pingers.
Looking at core/modules/system/tests/form_test, the term "Form constructor" is used 10 times but "@ingroup forms" only 5. But that's an inconsistency to be discussed in another issue.

I think this is good to go.

This looks right to me!

Committed and pushed to 8.x. Thanks!

Does this need backport to D7 as well?

Looks like it does need a backport. The file is
modules/simpletest/tests/ajax_forms_test.module

Looks the same to me. :)

Committed and pushed to 7.x. Thanks!