Part of the JavaScript selectors clean-up effort.
#1574470: Selectors clean-up
#1415788: Javascript winter clean-up

CommentFileSizeAuthor
#4 1751382-clean-up-file-js.patch2.85 KBdroplet
#3 core-js-1751382-3-file-selectors-clean-up.patch4.31 KBJelle_S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

use .on and .off
can probably be clean-up some more as well

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Issue tags: +Needs JavaScript testing

tag

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
Status: Active » Needs review
FileSize
core-js-1751382-3-file-selectors-clean-up.patch4.31 KB

This issue has been around long enough... Seems like a pretty straight-forward task at first sight, so here we go ;-)

droplet’s picture

droplet CreditAttribution: droplet commented
Issue summary: View changes
FileSize
1751382-clean-up-file-js.patch2.85 KB

Re-reroll patches & Clean up a bit more. No interdiff will be attached, please review whole patch. Thanks.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

That works, thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.