As part of #1415788: Javascript winter clean-up we're doing a jQuery-cleanup. All usages of .prev() and .next() have to be checked. If there is any filtering happening after these calls, they should be refactored to filter them within these calls.

Comments

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented

Also, although I'm not sure if this is in the scope of the issue and/or if it's considered best practice, but there are a lot of .prev('selector').eq(0) and .next('selector').eq(0). Should they be refactored to .prev('selector:first') and .next('selector:first')? Or is this something for #1649780: Remove first/last/odd/even classes in favor of CSS3 pseudo selectors ?

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Issue tags: +JavaScript, +JavaScript clean-up

Adding tags

nod_’s picture

nod_
Primary language French
Location Lille
commented

I don't want sizzle-specific selectors, but this one can work. Make sure you don't add any :last selector, that's all. update the summary in the clean-up meta as well :)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Fixed

Filtering part of this is ok already. The selector would help, we got specific issues for each files, that should be taken there.

Automatically closed -- issue fixed for 2 weeks with no activity.