Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Using Safari 1.2.4 under OS 10.3, the form elements for content administration are not legible. (The path is "admin/node".) I am not enough of a CSS whiz to directly propose a solution. But I am willing to test patches.
I attached a screenshot.
Comment | File | Size | Author |
---|---|---|---|
#15 | fieldset.patch | 1.51 KB | Junyor |
#9 | safari_float_render_0.diff | 1.29 KB | adrian |
#7 | safari_float_render.diff | 1.29 KB | adrian |
#4 | safari_error.jpg | 11.03 KB | adrian |
content_administration-Safari.jpg | 33.21 KB | njivy |
Comments
Comment #1
njivy CreditAttribution: njivy commentedOops. Wrong version.
Comment #2
matt westgate CreditAttribution: matt westgate commentedThis has been fixed.
Comment #3
(not verified) CreditAttribution: commentedComment #4
adrian CreditAttribution: adrian commentedI just found the admin menu similarly messed up in the 4.6RC.
I flushed my drupal.css just in case, but the bug definitely persist.
Comment #5
Junyor CreditAttribution: Junyor commentedThe same thing is happening in Opera. I tracked it down to having a floated object inside a fieldset. Firefox uses the fieldset as the containing block for the float, but Opera and Safari move the floated content outside of the fieldset.
Comment #6
Gábor HojtsySo then a container div might be a working solution.
Comment #7
adrian CreditAttribution: adrian commentedHere is a patch that adds a break , with a class of 'clear' , and adds a .clear class to the drupal.css file.
This is how I would fix it, but it's probably not semantically correct. But it does fix the problem..
Comment #8
adrian CreditAttribution: adrian commentederr. and it's a patch.
Comment #9
adrian CreditAttribution: adrian commentedI'm using the coffee defense as to why I missed the . infront of the .clear class
Comment #10
adrinux CreditAttribution: adrinux commentedI can't see any other way to fix that, adding an ID and setting height on the fieldset would be just as ugly imo - maybe re-engineering the whole form would work but this isn't really the time to do that! Steven will moan at you for using a br probably :)
Comment #11
Steven CreditAttribution: Steven commentedThe original commit referenced above did not fix the problem completely, it did make the node admin at least usable in Safari. Before, the form items would overlap eachother.
Adrian's fix seems to work, and the br is sort of excusable in this case, as the browser's behaviour is quite broken with regard to fieldsets. Usually I use <span> to avoid nasty br issues in IE, but there don't seem to be any in this case. <br class="clear"> could be considered a CSS version of <br clear="both"> which is transitional XHTML.
Commited to head.
Comment #12
Junyor CreditAttribution: Junyor commentedLooks good in Opera and Safari now, thanks.
The behavior of floats inside fieldsets is undefined in CSS, so it's not really that they're broken. They're just different. :)
Comment #13
moshe weitzman CreditAttribution: moshe weitzman commentedPerhaps this is a good spot to mention that the author and timestamp fields are broken on the node edit form in Safari. They have been busted for a long time. The browser won't even click into those fields, so they can't be changed. Perhaps the fix there is similar to the fix submitted in this issue.
Comment #14
Junyor CreditAttribution: Junyor commentedThe same solution will probably work there.
Comment #15
Junyor CreditAttribution: Junyor commentedHere's an alternative patch. Instead of adding a BR, if you set 'overflow: hidden' on the fieldset, it will expand to contain all floats. It works well in Opera, Firefox, Safari, IE6/Win, and IE5.2/Mac.
Also included in this patch is a fix for the problem Moshe mentioned. I removed the '.node-form fieldset { display: inline }' rule. The change didn't appear to cause any visual/functional differences in the above browsers, except Safari (now it works ;)).
Comment #16
Steven CreditAttribution: Steven commentedThis was fixed by recent core CSS changes.
Comment #17
(not verified) CreditAttribution: commentedComment #18
(not verified) CreditAttribution: commentedComment #19
(not verified) CreditAttribution: commentedComment #20
(not verified) CreditAttribution: commentedComment #21
(not verified) CreditAttribution: commented