Using Safari 1.2.4 under OS 10.3, the form elements for content administration are not legible. (The path is "admin/node".) I am not enough of a CSS whiz to directly propose a solution. But I am willing to test patches.

I attached a screenshot.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

njivy’s picture

Oops. Wrong version.

matt westgate’s picture

This has been fixed.

Anonymous’s picture

adrian’s picture

Priority: Normal » Critical
FileSize
11.03 KB

I just found the admin menu similarly messed up in the 4.6RC.

I flushed my drupal.css just in case, but the bug definitely persist.

Junyor’s picture

The same thing is happening in Opera. I tracked it down to having a floated object inside a fieldset. Firefox uses the fieldset as the containing block for the float, but Opera and Safari move the floated content outside of the fieldset.

Gábor Hojtsy’s picture

So then a container div might be a working solution.

adrian’s picture

FileSize
1.29 KB

Here is a patch that adds a break , with a class of 'clear' , and adds a .clear class to the drupal.css file.

This is how I would fix it, but it's probably not semantically correct. But it does fix the problem..

adrian’s picture

err. and it's a patch.

adrian’s picture

FileSize
1.29 KB

I'm using the coffee defense as to why I missed the . infront of the .clear class

adrinux’s picture

I can't see any other way to fix that, adding an ID and setting height on the fieldset would be just as ugly imo - maybe re-engineering the whole form would work but this isn't really the time to do that! Steven will moan at you for using a br probably :)

Steven’s picture

The original commit referenced above did not fix the problem completely, it did make the node admin at least usable in Safari. Before, the form items would overlap eachother.

Adrian's fix seems to work, and the br is sort of excusable in this case, as the browser's behaviour is quite broken with regard to fieldsets. Usually I use <span> to avoid nasty br issues in IE, but there don't seem to be any in this case. <br class="clear"> could be considered a CSS version of <br clear="both"> which is transitional XHTML.

Commited to head.

Junyor’s picture

Looks good in Opera and Safari now, thanks.

The behavior of floats inside fieldsets is undefined in CSS, so it's not really that they're broken. They're just different. :)

moshe weitzman’s picture

Perhaps this is a good spot to mention that the author and timestamp fields are broken on the node edit form in Safari. They have been busted for a long time. The browser won't even click into those fields, so they can't be changed. Perhaps the fix there is similar to the fix submitted in this issue.

Junyor’s picture

The same solution will probably work there.

Junyor’s picture

FileSize
1.51 KB

Here's an alternative patch. Instead of adding a BR, if you set 'overflow: hidden' on the fieldset, it will expand to contain all floats. It works well in Opera, Firefox, Safari, IE6/Win, and IE5.2/Mac.

Also included in this patch is a fix for the problem Moshe mentioned. I removed the '.node-form fieldset { display: inline }' rule. The change didn't appear to cause any visual/functional differences in the above browsers, except Safari (now it works ;)).

Steven’s picture

Status: Needs review » Fixed

This was fixed by recent core CSS changes.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Status: Fixed » Closed (fixed)