this is a simple patch to put the "Location(s)" title in a separate classed div, so that it can be modified via CSS.

CommentFileSizeAuthor
#8 location-172646-8.patch385 bytesAnonymous (not verified)
#1 location.module.maps_.patch394 bytesAnonymous (not verified)
location.module.title_.patch1.01 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Title: add div class for "Location(s)" title » add div class for maps links
StatusFileSize
new location.module.maps_.patch394 bytes

This similarly puts the the "See map: " section of node output into its own div which both allows it to be themed and resolves a problem I had where there was no line break between the location output and the start of the next field.

catch’s picture

catch
he/him
Primary language English
commented

Duplicate:
http://drupal.org/node/161703 - also had patch

yesct’s picture

yesct commented
Issue tags: +Location theming

I think that issue number had a typo in it, as it did not appear to be related.

I do remember reading an issue that talked about changing the map link. I'll try and find it and post back.

Also tagging.

yesct’s picture

yesct commented
Issue tags: +location theming map links

here it is.

#182786: Open map links in new window is related kind of.

Also, adding a tag.

yesct’s picture

yesct commented

marked #335955: Small display fix as a duplicate. It has sample code for adding a div too.

yesct’s picture

yesct commented

marked #375127: Minor UI improvement on user page as a duplicate. It suggested using paragraph tags to improve spacing.

yesct’s picture

yesct commented

related #396610: Theming seperate locations within same node wants to remove the links.

Anonymous’s picture

Anonymous (not verified) commented
Title: add div class for maps links » Add div class for map links
Version: 5.x-2.7 » 6.x-3.x-dev
Assigned: » Unassigned
Priority: Minor » Normal
StatusFileSize
new location-172646-8.patch385 bytes

Here's a patch for the latest .dev version. Can we get this committed?

Melissamcewen’s picture

Melissamcewen commented

Why hasn't this patch been committed yet? echo $map_link; seems to still not have a class.

Melissamcewen’s picture

Melissamcewen commented

OK, I am now reviewing this patch:
* Is the patch in unified diff format? +/- is good >< is bad? Yes
* Does the patch meet Drupal's coding standards? I don't see any.
* Is the code secure? Yes.
* If the patch makes major changes to a function or adds a new one, does it have appropriate code comments? No, it does not make major changes or a function or add a new one.
* Is the patch likely to cause performance issues? No
* Does the patch add theme functions or .tpl.php files where appropriate? Not applicable I think.
* If new pages are added, are they are in a logical place? If forms or other UI elements are added, are they intuitive and logical to use? Does it come with appropriate contextual help? Is the interface consistent? Not applicable
* If the patch is adding new functionality, does this apply only to the specific area it's affecting in core, or can it be applied to other areas and in contrib? Not applicable

yesct’s picture

yesct commented
Status: Needs review » Reviewed & tested by the community
ankur’s picture

ankur commented
Status: Reviewed & tested by the community » Fixed

Comitted to DRUPAL-6--3 and HEAD

yesct’s picture

yesct commented

http://drupal.org/cvs?commit=347448
http://drupal.org/cvs?commit=347446

Status: Fixed » Closed (fixed)
Issue tags: -Location theming, -location theming map links

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Location theming, +location theming map links

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.