Patch attached allows easier translation and it's also easier to understand for everyone as a key could be anything.

Files: 
CommentFileSizeAuthor
#8 theme_error.png7.58 KBdcam
#2 core+Change+wording+theme+key+to+theme+hook+for+translation+reasons-D8.patch1.21 KBhass
PASSED: [[SimpleTest]]: [MySQL] 39,980 pass(es). View
#1 core+Change+wording+theme+key+to+theme+hook+for+translation+reasons-D7.patch1.19 KBhass
PASSED: [[SimpleTest]]: [MySQL] 39,302 pass(es). View
core+Change+wording+theme+key+to+theme+hook+for+translation+reasons-D7.patch1.19 KBhass
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core+Change+wording+theme+key+to+theme+hook+for+translation+reasons-D7.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

hass’s picture

Status: Active » Needs review
FileSize
1.19 KB
PASSED: [[SimpleTest]]: [MySQL] 39,302 pass(es). View
hass’s picture

Version: 7.x-dev » 8.x-dev
FileSize
1.21 KB
PASSED: [[SimpleTest]]: [MySQL] 39,980 pass(es). View

D8 patch

BarisW’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks good, although an invalid theme hook call still results in this error:

Warning: call_user_func_array() expects parameter 1 to be a valid callback, no array or string given in theme_get_registry() (line 268 of core/includes/theme.inc).

But that should be another issue. This patch is fine ;)

catch’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks, theme hook is better here. Committed/pushed to 8.x.

hass’s picture

D7 Patch is in #1.

hass’s picture

Status: Patch (to be ported) » Needs review
hass’s picture

What is holding this patch back?

dcam’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
7.58 KB

The patch in #1 contains the same changes that were applied to D8. The attached image shows the error log messages before and after the patch was applied.

theme_error.png

The patch looks good to me. Marking as RTBC.

David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +7.22 release notes

I'm not sure why we're getting rid of the quotes, but this is an obscure enough log message that it doesn't matter much. Also, it's a string change, so I probably should have committed this earlier in the release cycle... but again, it's an obscure string - and also one that is completely wrong and confusing in its current form, so I think untranslated but correct might be better than translated but incorrect in this case :)

Therefore, committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/815faef

Automatically closed -- issue fixed for 2 weeks with no activity.