The categories filter is broken on the products view of the no demo store content :

Notice: Undefined index: value in views_handler_filter->exposed_form() (line 760 of /media/nfsdrive/stratus_kickstart_v2/www/commerce_kickstart/profiles/commerce_kickstart/modules/contrib/views/handlers/views_handler_filter.inc).
Notice: Undefined index: term_node_tid_multiple_vocabularies in views_handler_filter_term_node_tid->exposed_validate() (line 258 of /media/nfsdrive/stratus_kickstart_v2/www/commerce_kickstart/profiles/commerce_kickstart/modules/contrib/views/modules/taxonomy/views_handler_filter_term_node_tid.inc).

If I remove the filter, the message disappears.

CommentFileSizeAuthor
Error message79.08 KBGuGuss

Comments

vasike’s picture

Version: 7.x-2.0-beta1 » 7.x-2.x-dev

this is a normal issue as there are some vocabularies not built (Collection, Gender, etc...)
So probably we'll need (to define) 2 different products pages.
One default to be used for no demo content with less specific filters, fields and one which overwrites the default as it is now.

vasike’s picture

possible solutions (AFAICS):

  1. different views based on installation selection: demo, no demo, demo with additional
  2. rework the filter to use all the categories that finds about the nodes if there´s no vocabulary selected
haza’s picture

Status: Active » Needs review

Maybe we need to find a way to alter just those specific vocabularies ?

vasike’s picture

solution proposal: to build a new views filter "Content: Product Display Has taxonomy terms (from Multiple Vocabularies)"
- provides only vocabularies defined as term references in the Product Display content types
- if there's no vocabulary selected, use all these vocabularies.

could be built within Drupal Commerce Product Reference, so it could be used without Kickstart distribution.
In Kickstart could be used with no selected vocabulary.

vasike’s picture

Using a the a Views patch #1716826-14: Content: Has taxonomy terms from Multiple Vocabularies Filter
i create a new filter Product Display Has taxonomy terms (from Multiple Vocabularies)
this implements my previous defined solution proposal.
here is the commit : https://code.drupalcommerce.org/#/c/397/

vasike’s picture

Status: Needs review » Needs work

actually this new filter should be used also for the Products page.

vasike’s picture

Status: Needs work » Needs review

ReBuilt the Products page view.
commit rebased : https://code.drupalcommerce.org/#/c/397/

vasike’s picture

vasike’s picture

questions:

1. should this filter be part of Drupal Commerce?
2, should we change the Issue title: Product Display Has taxonomy terms (from Multiple Vocabularies) Views filter?

vasike’s picture

commit rebased https://code.drupalcommerce.org/#/c/397/

all it seems ok

bojanz’s picture

Assigned: vasike » bojanz
Status: Needs review » Needs work

Merged. Fixes our errors.

Assigning to me and setting "needs work" so that I can look into the Views handler.

bojanz’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.