The apps module has a line that tells users that Apps have been successfully installed during a distribution installation, but since it doesnt render until the next page load it ends up showing up on the following screen (http://drupal.org/files/apps-success-next-screen.png). This can be a bit confusing (since no other part of the Drupal profile installation process behaves this way) and I would recommend we do this silently (and only show errors).

CommentFileSizeAuthor
#3 apps-enable-success-1721548-3.patch542 bytesnedjo
#1 1721548-silent-success-condition-profile.patch568 bytespopulist
apps-success-next-screen.png13.04 KBpopulist
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

populist’s picture

populist CreditAttribution: populist commented
Status: Active » Needs review
FileSize
1721548-silent-success-condition-profile.patch568 bytes

Here is a patch that rejoices silently.

febbraro’s picture

febbraro CreditAttribution: febbraro commented
Status: Needs review » Fixed

Thanks. http://drupalcode.org/project/apps.git/commit/2e81c1d

nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo commented
Priority: Normal » Critical
Status: Fixed » Needs review
FileSize
apps-enable-success-1721548-3.patch542 bytes

With this change, on successful completion of the batch operation for enabling apps, the following message appears:

Fatal error trying to enable apps.

This is because the $success variable isn't tested before giving the fatal error message.

Fix attached.

febbraro’s picture

febbraro CreditAttribution: febbraro commented
Status: Needs review » Fixed

Fixes this and committed. Thanks nedjo.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.