Undefined index warning in user_menu_link_alter() when manually adding a "user" path as a shortcut

I think this is a bug in the user module; menu_link_save() does not specify that 'module' is required, so its existence shouldn't be assumed in the alter hook.

Also, the code comments in shortcut_set_save() explain why we don't want to set 'shortcut' as the module here (but rather rely on the default).

For Drupal 8, a better fix might be to consider moving the drupal_alter() call in menu_link_save() a little later (after the defaults have been added to the menu item); that way, the alter hook is actually working with a complete menu link record. If so, this patch could be for the menu system rather than the user module.

However, that change might not necessarily be backportable to Drupal 7.

I'm not sure what to do with this. I'm getting the error as well when customizing the shortcut bar. 7.22. I've added a few shortcuts and they seem to work. Do I need to be concerned about this re the site. Or is it just a problem when adding these links? Or should I use the patch above? Thanks for your patience with the question.

I wholeheartedly agree with #1 -- there is no expectation that module must be provided in the link.

Attached is a patch that checks for the key with isset(). Another approach would be to move the drupal_alter() call in menu_link_save() after the application of default values, but I feel like that change would be much more breaking.

I know the backport policy, but I'm bumping this to 7.x to get Testbot's attention.

Go home, Guy... you're drunk.

Re-roll with correct syntax.

Patch works for D7.

Setting to Active for D8 so we can get a D8 patch.

Not able to reproduce the problem in latest codebase of Drupal 8

I confirm this is not an issue for Drupal 8.

Patch #6 does the needful for Drupal 7.

Yeah, it looks like this code is now long gone from Drupal 8. And a test for something this minor is probably not worth it.

Committed to 7.x - thanks!