Closed (fixed)
Project:
Menu HTML
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Aug 2012 at 09:34 UTC
Updated:
15 Feb 2018 at 04:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
elwyn commentedI ran into the same issue today. Drupal 7.15, Menu HTML 7.x-1.x-dev
As well as the error mentioned above, the checkbox was not being set with the stored value.
I've fixed the issue by modifying menu_html.module.
Note in the code above I have also applied a bug fix for this issue: https://drupal.org/node/963256#comment-6339234 (checking if this content type actually has menus enabled for it) (the added "&& isset($form['menu'])").
Sorry I'm not sure how to make this into a .patch file! Hope that helps someone out.
Comment #3
myselfhimself commentedHello,
this patch works for me and helped me fix the following error:
Thank you very much !
Comment #4
vacilando commentedSame problem :-(
Comment #5
axe312 commented#2 also fixes the problem for me! pls add to core!
Comment #6
vacilando commented#2 is a solid solution; please apply it at least in dev.
Comment #7
dadderley commentedThis works for me.
Now if only I could make this happen in a superfish menu I would be in business,
Comment #8
dadderley commentedIt does not work with superfish 7.x-1.8
But it will work with the newest dev release of Superfish.
superfish 7.x-1.x-dev
Last packaged version: 7.x-1.9-beta5+1-dev
Last updated: December 9, 2012 - 17:32
Very cool.
Comment #9
energee commentedRolled for git/patch apply
Comment #10
drzraf commentedrerolled to apply against 7.x-1.x + fixes
isset($form['menu'])is often wrongmenu_html_menu_link_alterprototype takes only 1 argumentComment #11
drzraf commentedComment #12
drzraf commentedbrand new implementation
enjoy
Comment #13
gimpel commented@drzraf: your patch from #10 works fine, the one from #12 exhibits the initial issue again here.
Comment #14
drzraf commentedfixed for both forms (menu-item-form and node-edit-form)
Added a maxlength to 255 (
VARCHAR(255)) instead of 128 so we have more place allowed for html menu items than for classic menu.Last note: a hint to
special_menu_itemscould be useful as this is the only way to put a<span>instead of having the HTML surronded by a<a>.Comment #15
carolpettirossi commentedThe patches from #12 and #14 haven't worked for me.
I've applied patch from #10 and it works fine in Drupal 7.22.
Comment #16
drzraf commentedcould you please tell me what was the notice and which form were you filling ?
The module in #14 is the way to go: it's enhanced and uses the proper hooks.
Comment #17
LaurenW commentedI am seeing the same error above, but am not knowledgable in how to apply patches. Has this been incorporated into a dev version yet?
Thanks!
Comment #18
daveparrish commented#14 worked well for me except that I had a notice due to
$form['options']['#value']['html']not existing when I would edit a menu item.I rerolled a patch with that fix and a few changes to match Drupal coding standards.
BTW, I patched the module by using git to download the module (
git clone http://git.drupal.org/project/menu_html.git), checked out the 7.x branch (git checkout 7.x-1.x), and then applied the patch (git apply 1716906-14-clean-hook-implementation.patch). I hope that helps some folks.Comment #19
dooug commentedthe patch in #18 worked for me. It also resolved this issue: #1991962: Remember 'allow html' setting.
I can also second comment #8 that you'll need to upgrade to Superfish 7.x-1.9 for these to work together.
Comment #20
paulrooney commented#18 worked for me as well. Thanks!
Comment #21
Exploratus commented#18 worked for me also.
Comment #22
dooug commentedComment #23
byue commentedAllow HTML checkbox is gone after apply patch 18
Comment #24
gilsbert commentedHi.
This issue is still happening on the last dev version (7.x-1.x-dev - 2013-set-30).
I also confirm #23. The patch #18 removes the warning/notice message but it does make the option "allow HTML" disappear.
Comment #25
gilsbert commentedUpdating the status!
Comment #26
jeremymcminn commentedAny updates on this?
Comment #27
daveparrish commentedWhich page is "Allow HTML" not showing up? It should show on both the node forms and the menu item form. For the node forms, the content type needs to have a menu enabled. I'm happy to fix the issue, but I haven't been able to reproduce.
Comment #28
gilsbert commentedHi.
I did a new test today. The "allow html" option is showing at menu item and node forms.
I dont know what I did different... maybe a "flush cache"?
That way I'm changing my report to: fixed!
Will patch #18 get incorpored into the official release?
Regards,
Gilsberty
Comment #29
daveparrish commentedI'm not the maintainer. Perhaps gagarine can help get the patch incorporated.
I've changed the status to "reviewed & tested by the community". Hopefully that will bring this issue to the attention of the maintainers.
Comment #30
gagarine commentedCommitted. Thanks for your works. https://drupal.org/commitlog/commit/8038/96ec175646e8237c16593f9dd97ca46...
Comment #31
gilsbert commentedHi.
I tested 7.x-1.0 of october's 19th and the issue is gone.
Thank you very much.
Regards,
Gilsberty
Comment #33
imanoop commentedTo "fix" this problem you must open Structure > Content Types > Page again and just edit and save it. Error message will be gone.
You will have to do this for all the content types to resolve this completely.
Copied!
Thanks,
Anoop Singh