Need to update {users}_uid_seq and {role}_rid_seq in modules/system/system.install [#171536]

system.install creates the role table with the "rid" field of type "serial" which automatically creates a sequence called "{role}_serial_rid_seq" and sets the default value for the field to "nextval('{role}_serial_rid_seq')".

Howver, the system.install script then goes on to insert two records, explicitly setting their "rid" values to DRUPAL_ANONYMOUS_RID and DRUPAL_AUTHENTICATED_RID, without updating the sequence.

As a result, adding roles to a new install will fail twice before succeeding.

The fix is to update the sequence, setting currval to the greater of DRUPAL_ANONYMOUS_RID and DRUPAL_AUTHENTICATED_RID.

Patchfile attached.

Comment	File	Size	Author
#8	system_install-postgres_seqs.patch	1.36 KB	halcyonCorsair
#8
#2	modules-system-system.install_0.patch	457 bytes	pillarsdotnet
#2
	modules-system-system.install.patch	472 bytes	pillarsdotnet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pillarsdotnet CreditAttribution: pillarsdotnet commented 29 August 2007 at 16:59

Probably should mention that this only affect postgresql users.

Not sure if the proper "Component" should be:

system.module
install system
postgresql database

Comment #2

pillarsdotnet CreditAttribution: pillarsdotnet commented 8 September 2007 at 20:19

File	Size
modules-system-system.install_0.patch	457 bytes

Bah! Named the sequence wrong. Fixed and re-rolled the patch.

--- orig/drupal/modules/system/system.install   2007-07-19 01:39:25.000000000 -0400
+++ patched/drupal/modules/system/system.install        2007-09-08 16:12:17.000000000 -0400
@@ -882,6 +882,8 @@
         UNIQUE (name)
       )");

+      db_query("SELECT setval('{role}_rid_seq',".max(DRUPAL_ANONYMOUS_RID,DRUPAL_AUTHENTICATED_RID)."));");
+
       db_query("CREATE TABLE {blocks_roles} (
         module varchar(64) NOT NULL,
         delta varchar(32) NOT NULL,

Comment #3

bdragon CreditAttribution: bdragon commented 10 September 2007 at 15:49

http://drupal.org/node/174071 marked as duplicate.

Comment #4

pillarsdotnet CreditAttribution: pillarsdotnet commented 15 September 2007 at 16:08

Title:

Need to update {role}_serial_rid_seq in modules/system/system.install

» Need to update {role}_rid_seq in modules/system/system.install

Adjust subject line.

Comment #5

drumm

he/him

NY, US

CreditAttribution: drumm commented 17 September 2007 at 01:21

Version:	5.2	» 5.x-dev
Status:	Needs review	» Fixed

Committed to 5.x. Please look over Drupal 6.x, which may have this issue.

Comment #6

ned0r CreditAttribution: ned0r commented 1 October 2007 at 00:11

+ db_query("SELECT setval('{role}_rid_seq',".max(DRUPAL_ANONYMOUS_RID,DRUPAL_AUTHENTICATED_RID)."));");

should really be ...

+ db_query("SELECT setval('{role}_rid_seq',".max(DRUPAL_ANONYMOUS_RID,DRUPAL_AUTHENTICATED_RID).");");

i.e. you have one too many closing parens :-(

This makes stuff break in nasty ways :(

Comment #7

pillarsdotnet CreditAttribution: pillarsdotnet commented 1 October 2007 at 02:17

Status:

Fixed

» Needs work

ned0r wrote:

... i.e. you have one too many closing parens ...

You're right; sorry about that. Changing Status.

Comment #8

halcyonCorsair CreditAttribution: halcyonCorsair commented 1 June 2010 at 12:45

Title:	Need to update {role}_rid_seq in modules/system/system.install	» Need to update {users}_uid_seq and {role}_rid_seq in modules/system/system.install
Version:	5.x-dev	» 6.x-dev
Priority:	Normal	» Critical
Status:	Needs work	» Needs review
Issue tags:		+PostgreSQL