Right now commerce_kickstart_jirafe has a huge and confusing settings page where you select the product node types and appropriate categories, to be used by Jirafe.

In the meantime, we added the commerce_product_reference_node_types() function to Commerce which allows us to kill the node type part of the configuration form completely.
This leaves the category part. We also know which vocabularies are used by the product display node types, so that doesn't need to be configurable either.
Fixing #1685096: The collection view at taxonomy/term needs to work for all vocabularies will probably require changing the current taxonomy code, so in order to avoid rebases and reworks, we should wait for that issue to be done first before approaching this part of cleanup.

Comments

bojanz’s picture

bojanz commented
Title: Automatically configure commerce_kickstart_jirafe » Remove commerce_kickstart_jirafe
Assigned: Unassigned » haza

We want to remove the entire module.
The hook_menu_alter and hook_init implementations should move to commerce_kickstart_menu.
The logic in commerce_kickstart_jirafe_jirafe_tracking_data_alter() should live in Jirafe itself, but with the following modifications:
1) Instead of taking the product node types from:

$db_node_types = variable_get('kickstart_jirafe_types', array());

we want to take them from commerce_product_reference_node_types().
2) Instead of taking the terms from:

$db_terms = variable_get('kickstart_jirafe_terms', array());

we want a custom function that goes through the product node types, takes term reference fields attached to them, assembles a list of vocabularies referenced by those fields. So it returns product display vocabularies.
Then, our tracking function can just check if the vocabulary of the current term is in the list of product display vocabularies.

bojanz’s picture

bojanz commented
Status: Active » Fixed

Merged in https://code.drupalcommerce.org/#/c/291/

Automatically closed -- issue fixed for 2 weeks with no activity.