A large fraction of menu module is admin pages/forms - let get them out of the normal page load re: http://groups.drupal.org/node/4179

CommentFileSizeAuthor
#5 menu_split_3.patch44.66 KBpwolanin
#3 menu_split_2.patch24.5 KBpwolanin
#1 menu_split_1.patch45.93 KBpwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Active » Needs review
FileSize
menu_split_1.patch45.93 KB

nice - about half the module can be moved to the .inc file

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Needs work

Doesn't apply. One hunk fails.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs work » Needs review
FileSize
menu_split_2.patch24.5 KB

Ah, the menu update patch touched some of this.

Here's a quick re-roll.

Crell’s picture

Crell CreditAttribution: Crell commented
Priority: Normal » Critical
Status: Needs review » Needs work

I think you forgot the -N. There's no menu.admin.inc file created.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs work » Needs review
FileSize
menu_split_3.patch44.66 KB

well, that's what I get for rolling patches when I should be in bed...

how about this one

dvessel’s picture

dvessel CreditAttribution: dvessel commented
Status: Needs review » Reviewed & tested by the community

Works for me. tested the menu admin page and setting menus from the node edit forms. Not sure editing the menus from nodes is affect but it works.

Great cleanup job.! Wonder how much memory is being saved with all the split patches. :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Great, committed!

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)