Comments

Wim Leers’s picture

To get copy/paste plus <strong> instead of <b> to work well, we'll also need #1701522: Add our own formattings transformation handler (i.e. when pasting, always use <strong>, never use <b>).

Wim Leers’s picture

Project:Edit» Spark
Issue summary:View changes

Updated issue summary.

Wim Leers’s picture

Project:Spark» Edit

Bugs in edit/edit_aloha fixed while working on this, both related to edit assuming edit_aloha is enabled:
- http://drupalcode.org/project/edit.git/commit/2d52cc6
- http://drupalcode.org/project/edit.git/commit/e1785bf

Wim Leers’s picture

Bugs encountered when using jQuery 1.7, which Jesse just added the other day to be able to have cleaner code in the Layouts code:
- http://drupalcode.org/project/edit.git/commit/5a83227
- http://drupalcode.org/project/edit.git/commit/4418cc4
- http://drupalcode.org/project/edit.git/commit/11c38c8
- http://drupalcode.org/project/edit.git/commit/074e39e

And one more bug that I found that wasn't due to jQuery 1.7:
- http://drupalcode.org/project/edit.git/commit/0ac68d5 (when you changed a field through an in-place form on a non-node page, the "Save" button wouldn't become blue/clickable because no changes were being detected)

Wim Leers’s picture

StatusFileSize
new768 bytes
Wim Leers’s picture

Wim Leers’s picture

Uploaded patches are to be used by our make file:
- #5: necessary to be able to override their custom UI
- #6: pull requests that have not yet been merged into a release that is available for download

All are used in http://drupalcode.org/project/spark.git/commit/3b1c0f5.

webchick’s picture

Remaining wrap-up steps:

1) Make the default filtered HTML format look like https://dl.dropbox.com/u/80682862/d.o/2012/spark%20edit%20wysigyg%20text...
2) add some img with a data-caption and data-align atrribute to the example node body

I'm going to try and knock this out.

jessebeach’s picture

StatusFileSize
new1.36 KB
new1.02 KB

Two patches weren't applying so I've rerolled them.

Wim Leers’s picture

@jessebeach: can you describe the differences between my patches and yours? I really would like to understand what went wrong there. (And I'd also like to understand why it did work on my machine … repeatably.)

webchick’s picture

Project:Edit» Spark

Moving this to the Spark queue since it's a meta issue.

webchick’s picture

Status:Active» Fixed

WOOHOO. Ok, apart from #1718336: Emphasis and Strong are getting a Bold icon for some reason, which we need to fix before I can tag a new Spark release, I believe this sucker is D-O-N-E! *So* exciting to see things coming together like this!

Wim Leers’s picture

Should all meta issues always live in the Spark issue queue maybe?

jessebeach’s picture

@Wim Leers, re: #1702248-10: [Meta] As a site builder, I would like to download a version of Spark with the WYSIWYG tools all ready to go, it was just an issue of line numbers. The changes in your original patches seemed to be 25 lines or so higher in the code than when I rebuilt them. Maybe the Aloha folks added some code and rebuilt the CDN released version of the code between when you rolled them and when I tried to apply them.

Wim Leers’s picture

#15: hm, ok, weird. Simple line offsets have never caused patches to fail in the past for me though. Very weird. Thanks for letting me know :)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

Updated issue summary.