Replace remaining references to drupal_attributes() with new Attributes()

This should be an easy enough task.

#1290694: Provide consistency for attributes and classes arrays provided by template_preprocess() went in, so no need for this to be postponed any more.

First pass. I didn't remove the actual drupal_attributes() array, I just updated the calls and documentation.

Each file should have use Drupal\Core\Template\Attribute; at the top and refer to it as just "Attribute" inline.

The code conversion looks good, just some doc issues left:

+++ b/core/includes/common.incundefined
@@ -2296,7 +2298,8 @@ function drupal_attributes(array $attributes = array()) {
+ *     to work in a call to
+ *     Drupal\Core\Template\Attribute($options['attributes']).

I'm not sure that the wording makes as much sense now that it's a constructor and not a function.

+++ b/core/includes/form.incundefined
@@ -2794,7 +2795,8 @@ function theme_fieldset($variables) {
+ *       is currently done by passing all attributes to
+ *       Drupal\Core\Template\Attribute.

Same wording issue.

+++ b/core/lib/Drupal/Core/Template/Attribute.phpundefined
@@ -33,9 +33,9 @@ use IteratorAggregate;
  * Most of the time this object is not created directly, but
- * instantiated by drupal_attributes().
+ * instantiated by Drupal\Core\Template\Attribute.
  *
- * @see drupal_attributes()
+ * @see Drupal\Core\Template\Attribute

This should just be removed wholesale :)

+++ b/core/modules/field/field.moduleundefined
@@ -1107,17 +1108,17 @@ function template_process_field(&$variables, $hook) {
+  // here. For best performance, only call Drupal\Core\Template\Attribute when
+  // needed, and note that template_preprocess_field() does not initialize the

Same wording issue.

+++ b/core/modules/user/user.moduleundefined
@@ -1365,7 +1366,7 @@ function template_process_username(&$variables) {
  *   - attributes: An array of attributes to pass to the
- *     drupal_attributes() function if not linking to the user's page.
+ *     Drupal\Core\Template\Attribute class if not linking to the user's page.

Same wording issue.

Hopefully this is a bit better.

#8: replace_drupal_attributes-1700382-8.patch queued for re-testing.

Patch no longer applies. Re-roll against current head.

Reviewed patch after re-roll. All seems to be fine.
The only place "drupal_attributes()" function remains it the "common.inc" where it is declared (although just as a wrapper for the new "Attributes" class.

Actually drupal_attributes() itself should also be removed. No need to keep a useless function around.

Removed drupal_attributes(), and rerolled the patch. Looks like some unrelated changes made it in to the last one, which have now been removed.

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/AttributesUnitTest.php
@@ -42,9 +43,9 @@ class AttributesUnitTest extends UnitTestBase {
diff --git a/core/modules/system/system.admin-rtl.css b/core/modules/system/system.admin-rtl.css

+++ b/core/modules/system/system.admin-rtl.css
@@ -57,11 +57,11 @@ table.screenshot {
diff --git a/core/modules/system/system.admin.css b/core/modules/system/system.admin.css

+++ b/core/modules/system/system.admin.css
@@ -222,11 +223,11 @@ table.screenshot {
diff --git a/core/modules/system/system.base-rtl.css b/core/modules/system/system.base-rtl.css

+++ b/core/modules/system/system.base-rtl.css
@@ -40,13 +40,13 @@ a.tabledrag-handle .handle {
diff --git a/core/modules/system/system.base.css b/core/modules/system/system.base.css

+++ b/core/modules/system/system.base.css
@@ -170,7 +170,7 @@ table.sticky-header {
diff --git a/core/modules/system/system.maintenance.css b/core/modules/system/system.maintenance.css

+++ b/core/modules/system/system.maintenance.css
@@ -41,12 +41,12 @@
diff --git a/core/modules/system/system.theme-rtl.css b/core/modules/system/system.theme-rtl.css

+++ b/core/modules/system/system.theme-rtl.css
@@ -80,7 +80,7 @@ ul.primary li a {
diff --git a/core/modules/system/system.theme.css b/core/modules/system/system.theme.css

While those are nice, they clearly are not related to this issue. :-)

Yikes! Hopefully this is ok.

I had read this a couple times before, and I trust the interdiff (thanks for providing that!). RTBC. Cool stuff! :-)

#18: replace_drupal_attributes-1700382-18.patch queued for re-testing.

I will reroll this today if someone doesn't get to it first.

Reroll.

what the

Only reroll, back to RTBC.

Committed/pushed to 8.x, thanks!

Hmm this isn't actually covered in #1727592: Attributes and classes arrays have been combined together into Attribute object - it doesn't mention that drupal_attributes() has been completely removed. Re-opening for the addition to the change notice.

Added notes to the change record, see here: http://drupal.org/node/1727592/revisions/view/2293888/2336148

Hope it's ok for me to close this issue.

Thanks. Moving to "fixed" though to keep it in front of people watching open issues. The system will automatically move it to "closed (fixed)" after 2 weeks of no activity.

Back to original priority. "critical" was only for the change notice.

Adding tag.