On fields ui, when creating a new field, this odd behavior prevents further changes to machine name.
After editing a field machine name, then re-ordering the field, the machine name field disappears.

Here are screenshots:
 edit the machine name when adding a field
 re-order the field

This bug definitely applies to 7.x-dev, and I assume to 8.x as well since field ui doesn't seem to have changed all that much.

Comments

nod_’s picture

Status: Active » Needs review
Issue tags: +JavaScript
StatusFileSize
new706 bytes
new678 bytes

That's a pretty crappy bug.

Don't forget the JavaScript tag next time :)

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Works perfect, for both versions.

webchick’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs backport to D7

Committed and pushed to 8.x. Thanks!

For whatever reason this didn't apply cleanly to 7.x, so moving to backport.

nod_’s picture

Issue tags: +Novice, +js-novice

tag

jfhovinne’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new678 bytes

Tested core-js-machine-name_tabledrag-1700210-1-D7-do-not-test.patch from #1, which applies cleanly against 7.x-dev and fixes the bug, so renaming the file and submitting for testing.

aaronbauman’s picture

Status: Needs review » Reviewed & tested by the community

patch in #5 solves the issue for me.
nice work, folks

nod_’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs JavaScript testing

Sorry putting back as NW since we need a test scenario added to this page http://drupal.org/node/1777342 and hopefully some testswarm code.

ZenDoodles’s picture

Version: 7.x-dev » 8.x-dev

Hey @nod_
I'm assuming the testswarm tests should be for 8x first? Then we can backport the whole kit and caboodle.

nod_’s picture

owww :( testing tabledrag suck big time.

But yes, the testing page http://drupal.org/node/1777342 needs updating.

s_leu’s picture

Version: 8.x-dev » 7.x-dev

This is no longer a problem in D8 since the tabledrag is now only available in the manage form display tab where no only already saved fields will appear.

  • webchick committed 5d61612 on 8.3.x
    Issue #1700210 by nod_, aaronbauman: Fixed After editing a field machine...

  • webchick committed 5d61612 on 8.3.x
    Issue #1700210 by nod_, aaronbauman: Fixed After editing a field machine...
sutharsan’s picture

Issue summary: View changes
Issue tags: -JavaScript, -Novice, -js-novice +JavaScrip

Removing Novice tag, 'Needs JS testing' does not qualify for novice.

  • webchick committed 5d61612 on 8.4.x
    Issue #1700210 by nod_, aaronbauman: Fixed After editing a field machine...

  • webchick committed 5d61612 on 8.4.x
    Issue #1700210 by nod_, aaronbauman: Fixed After editing a field machine...

  • webchick committed 5d61612 on 9.1.x
    Issue #1700210 by nod_, aaronbauman: Fixed After editing a field machine...
xjm’s picture

Issue tags: -JavaScrip +JavaScript
poker10’s picture

Version: 7.x-dev » 8.0.x-dev
Status: Needs work » Fixed

I think this can be closed as fixed in 8.x-dev (it was commited in #3 and is no longer relevant for 9.4.x-dev as there is no tabledrag on that page). According to the backport policy we should continue with the D7 fix in the separate D7 issue here: #2649926: [D7] Field UX: machine name disappears.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.