Does it really make sense to use separate mailhide keys for each input filter?

Particularly now that mailhide has its own module, it makes more sense to me to use a settings page. That way, if you want to use it on, say, the default and the full html filters, you don't have to reenter keys for each filter.

CommentFileSizeAuthor
#2 recaptcha_mailhide.module.patch2.79 KBrobloach

Comments

robloach’s picture

Assigned: Unassigned » robloach

You're right! I'll work on it sometime in the next 24 hours.

robloach’s picture

StatusFileSize
new2.79 KB

What if it still used the Input Filter's configuration, but get and set globally available public and private keys? So, instead of keys unique to that filter, they are site dependent. This would save us having to put another menu item on there as well as allow us to put filter unique stuff in later on if we want to. The attached patch will hopefully do it (I didn't do intensive testing).

Thoughts?

robloach’s picture

Status: Active » Needs review
kthagen’s picture

Status: Needs review » Reviewed & tested by the community

It works for me

kthagen’s picture

BTW, this change does require those who are upgrading to reenter the keys, so a warning in README.txt is probably appropriate.

robloach’s picture

Status: Reviewed & tested by the community » Fixed

Yay, thanks kthagen.

Anonymous’s picture

Status: Fixed » Closed (fixed)