Error with multiple flags

+ 1

+ 1

+1
The problem here is because dlike uses flag_get_counts() function from flag module. This function count for flags in specific node and it doesn't matter which type of flag was made, like, abuse or whatever.
I think it's better to clone this function into dlike module and add flag filter to it. Something like:

->condition('f.name', $flag_name)

Here's how I handle it:
I cloned flag_get_counts() function from flag module with some changes as follows:

// I renamed function to avoid names conflict
function dlike_flag_get_counts($content_type, $content_id, $flag_name, $reset = FALSE) {
  static $counts;

  if ($reset) {
    $counts = array();
    if (!isset($content_type)) {
      return;
    }
  }

  if (!isset($counts[$content_type][$content_id])) {
    $counts[$content_type][$content_id] = array();
    $query = db_select('flags', 'f');
    $query->leftJoin('flag_counts', 'fc', 'f.fid = fc.fid');
    $result = $query
      ->fields('f', array('name'))
      ->fields('fc', array('count'))
      ->condition('f.name', $flag_name) // this is new flag filter condition
      ->condition('fc.content_type', $content_type)
      ->condition('fc.content_id', $content_id)
      ->execute();
    foreach ($result as $row) {
      $counts[$content_type][$content_id][$row->name] = $row->count;
    }
  }

  return $counts[$content_type][$content_id];
}

Then in dlike.inc file in line 51 I replaced this:

$dlike_append_count = flag_get_counts($flag_type, $content_id);

Into this

$dlike_append_count = dlike_flag_get_counts($flag_type, $content_id, $flag_name);

Hope this will help everyone and it will be implemented in dlike.

Cheers

Your fix works.

Thank you for the great module

please make a path.

where shound put this code ?

<?php
// I renamed function to avoid names conflict
function dlike_flag_get_counts($content_type, $content_id, $flag_name, $reset = FALSE) {
  static $counts;

  if ($reset) {
    $counts = array();
    if (!isset($content_type)) {
      return;
    }
  }

  if (!isset($counts[$content_type][$content_id])) {
    $counts[$content_type][$content_id] = array();
    $query = db_select('flags', 'f');
    $query->leftJoin('flag_counts', 'fc', 'f.fid = fc.fid');
    $result = $query
      ->fields('f', array('name'))
      ->fields('fc', array('count'))
      ->condition('f.name', $flag_name) // this is new flag filter condition
      ->condition('fc.content_type', $content_type)
      ->condition('fc.content_id', $content_id)
      ->execute();
    foreach ($result as $row) {
      $counts[$content_type][$content_id][$row->name] = $row->count;
    }
  }

  return $counts[$content_type][$content_id];
}
?>

Tweak

after modify the dlike.inc file, the issue remains, I used the following code to created two flags at product display page. It shows undefiend index like .......

Is there a way to hide the PHP error message,
Notice: Undefined index: like in dlike_append() (line 50 of /var/www/drupal/sites/all/modules/dlike/dlike.inc).

@Vlad Stratulat

print flag_create_link('like', arg(1));

print flag_create_link('bookmarks', arg(1));

I think this could be resolved by changing 1 line of code. Patch provided.

#8 is working fine for dlike 7x-2x.

I can confirm this problem sadly still exists for the 7.x-3.x version. Please also fix it there.

In 7.x-3.x version it seems to be just an isset-check which is missing.

To fix it, in dlike.inc file, about line 47, just replace

if ($dlike_append_count  && $dlike_append_count[$flag_name] > 0) {

into this

if ($dlike_append_count && isset($dlike_append_count[$flag_name]) && $dlike_append_count[$flag_name] > 0) {

Patch for 7.x-3.0 attached.

Patch is not being applied . Needs reroll.

Try this, re-rolled against latest dev. I've removed the initial check to see if the variable exists, because isset() actually takes care of that.