Added features and scenario for creating a new issue page

Comments

sachin2dhoni’s picture

Hi,

Added the feature file create_issues.feature file for create a new issue.

Please check this and suggest.

Thanks,
Suresh

sachin2dhoni’s picture

Issue tags: +sprint 1
sachin2dhoni’s picture

Status: Active » Needs review
eliza411’s picture

Status: Needs review » Needs work

Please review for the pattern of one given, when, and then. I think everything between the first When and the last Then should be an And.

sachin2dhoni’s picture

Assigned: sachin2dhoni » Unassigned
Status: Needs work » Needs review

I have corrected the pattern as suggested and updated the same.
please check.

eliza411’s picture

Title: Write Feature For Creating a new issue(create_issues.feature) » Write Feature For Creating a new issue (create_issues.feature)
Project: Drupal.org Testing (.phar) » Drupal.org BDD
Component: User interface » Tests
Status: Needs review » Fixed

This was committed to doobie with some adjustments.

Please review and re-open as needed
http://drupalcode.org/project/doobie.git/commit/323c65f1de

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

eliza411’s picture

I made some adjustments to this to provide a single Given/When/Then in commit 18e31d6

kssundar’s picture

Version: » 7.x-1.x-dev
Component: Tests » Test needs update
Assigned: Unassigned » kssundar
Status: Closed (fixed) » Patch (to be ported)
Issue tags: +sprint 18

Need 7.x update

kssundar’s picture

Status: Patch (to be ported) » Needs review
eliza411’s picture

Status: Needs review » Needs work

This test is hanging indefinitely at but I can complete all the steps manually.

As far as I know I have the latest version of everything. Does this happen for you and if so, can you look into why?

  Scenario: Create an issue from a specific project's issue page # features/project/create_issues.feature:27
    Given I am logged in as "site user"                          # FeatureContext::iAmLoggedInAs()
    And I am on "/project/issues/achievements"                   # FeatureContext::visit()
kssundar’s picture

First run:

2 scenarios (2 passed)
19 steps (19 passed)
1m6.952s

Second run:

2 scenarios (2 passed)
19 steps (19 passed)
0m47.337s

Third run:

2 scenarios (2 passed)
19 steps (19 passed)
1m8.908s

Ran this thrice in a row and could not find any issues with it.

kssundar’s picture

Status: Needs work » Needs review
eliza411’s picture

Status: Needs review » Fixed

It has to be something on my system. I could run this successfully from bddtest.drupal.org, so I'll work on my system.

I'm satisfied to set this issue to fixed since they're all passing on everyone else's system, including the one that will be running the ci tests.

eliza411’s picture

Status: Fixed » Needs work

Wait, one last question: The second scenario doesn't seem to require javascript - any reason not to use goutte?

kssundar’s picture

Status: Needs work » Needs review
Issue tags: +sprint 19

Added javascript scenario for first scenario - http://drupalcode.org/project/doobie.git/commit/e978eb4

eliza411’s picture

Status: Needs review » Fixed

Great, thanks. And with the most recent versions of everything, it's even working on my system.

Automatically closed -- issue fixed for 2 weeks with no activity.