API page: http://api.drupal.org/api/drupal/core%21modules%21field%21field.info.inc...

Enter a descriptive title (above) relating to field_info_field, then describe the problem you have found:

I can *see* that on failure I will get a NULL, but the PHPDoc is missing it.

#3 field_info_field-does-not-1689394-3.patch584 bytesmjonesdinero
PASSED: [[SimpleTest]]: [MySQL] 37,297 pass(es). View
#1 added_Return_message.patch683 bytesronan.orb
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in added_Return_message.patch. View


ronan.orb’s picture

683 bytes
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in added_Return_message.patch. View

Not sure if the *.patch files have a standard format. I created this one with hg and phpstorm.

jhodgdon’s picture

Title: Return on failure missing » field_info_field() does not document return value on failure
Status: Active » Needs work
Issue tags: +Novice, +needs backport to D7

Thanks for the patch! It isn't quite the right format -- you need to use Git to make a patch, and when uploading, set the issue status to "needs review" to trigger both human and test-bot reviewers that you have made a patch.

See http://drupal.org/node/707484 , or http://drupal.org/novice if you need more extensive help in getting started as a Drupal Core contributor.

Meanwhile, perhaps someone can re-roll this patch? Please also put "the" in "NULL if *the* field was not found." :)

mjonesdinero’s picture

Assigned: Unassigned » mjonesdinero
Status: Needs work » Needs review
584 bytes
PASSED: [[SimpleTest]]: [MySQL] 37,297 pass(es). View

attach is the re-rolled patch

jhodgdon’s picture

Status: Needs review » Fixed

Thanks! Committed to 7.x and 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.