- On the site Home page
- Says "Come for the software, stay for the community" under the big Drupal text in banner area (plus the paragraph underneath). Neither the "Come for..." nor the next paragraph should appear on any of the other pages in the banner area, just the home page.
- Should have a search box with options in middle right of banner area.
- Should have navigation at the top right of the banner area (Get Started, Community, Documentation, etc.) [all pages, not just home]
- If logged in, you should have at the bottom of the banner, tabs saying Drupal Homepage, Your Dashboard, Logged in as..., etc. If not logged in, you get Drupal Homepage, Log in/register. [this applies to all pages, not just home]
- Below banner: Left column is static text. Center column should have a sample "Sites made with drupal". Right column should have the Develop with Drupal area (with stats and some static links below), and below that an ad.
- Bottom section should have a count of how many people/languages power Drupal, a map that shows updates, and the tabbed sections to the right: News, Docs updates, Forum posts, Commits.
- Then there's the bottom nav, which I think is static text.
Comments
Comment #1
eliza411 commentedUpdating tag and moving to the main project
Comment #2
pradeeprkara commentedtagging
Comment #3
eliza411 commentedThis set of tests will definitely need to be split into separate files. Feel free to break up this issue, too, if that's helpful.
One of those files will be testing the functionality of the map, which I've opened a new issue for here: #1792788: Front page: Map
Comment #4
pradeeprkara commentedComment #5
pradeeprkara commentedComment #6
pradeeprkara commentedGetting an HTTP Error 500 (Internal Server Error) for http://git6site.devdrupal.org/start and http://git6site.devdrupal.org/download.
The same URLs work on drupal.org though.
Comment #7
eliza411 commentedTag these with known_git6failure, I'd say. I'm hoping we can get a fresh build by tomorrow.
Comment #8
pradeeprkara commentedCreated two features: /drupalorg/homepage_content.feature and /drupalorg/homepage_header.feature for content and header regions respectively.
As different issues exist for map and News tab contents, they have been skipped.
Tagged as @known_git6failure and @retest_after_next_build for the login issues.
Also git6site doesn't have count against "Distributions" in Develop with Drupal section.
Please review be1a60d
Comment #9
eliza411 commentedThis looks like it's doing what was requested. Removed @wip tags and added a specific text tag to the header feature.
Comment #10
pradeeprkara commentedAs I found timeout issues for some of the scenarios, marked them as @flaky.
Also in Scenario Outline: Check bottom header tabs as authenticated user, excluded
Logged in as site userandLog outfromThen I should see the following <tabs> in "bottom header" areaand added toAnd I should see the following <links> in "bottom header" areaas they are treated as links.Please see the commits
66b2917, 6c01bca
Comment #11
pradeeprkara commentedTagging
Comment #12
eliza411 commentedThese look good to me ...
Comment #13
eliza411 commentedneeds porting to 7.x
Comment #14
tvn commentedcan we rename this files to frontpage_[something].feature please?
I added front tag and updated some descriptions (http://drupalcode.org/project/doobie.git/commit/e123686).
frontpage_content.feature needs to test:
- "Get started with Drupal" and "Learn about Disctributions" links work
- Image under Sites made with Drupal shows up
Let's move last scenario "Check footer links and text" out to frontpage_footer.feature
frontpage_header.feature:
- can we also test that logo shows up?
- 1 more scenario to test that on pages other than frontpage "Refine your search" is a link
Also, do we have tests for ad in the right column of the front page anywhere? If not, we should add them to content file.
Comment #15
pradeeprkara commentedAs I can see an ad in an iframe at drupal.org frontpage and an image at git6site, looking for the contents of ad wrapper div against null would be sufficient for ads in right side column?
Comment #16
eliza411 commentedAssigning to be sure this shows up on tvn's radar.
Comment #17
tvn commentedcan we check specifically for
<a>tag being present inside that div? Just to eliminate the case when that div has some other divs/tags inside, but no actual ad for some reason.Comment #18
pradeeprkara commentedseparated the features and renamed to
frontpage_header.feature,frontpage_content.featureandfrontpage_footer.feature.Updated descriptions as well.
As the logo and banner are background images, didn't find a way to identify them but banner can be identified by homepage link
Added new scenario to check "Refine your search" link and the visibility of filter options upon clicking it.(selenium is required here)
The step definition for ad is looking for links. (Iframe content also has been considered)
Marked scenarios which don't work as expected as
@known_git6failurePlease review the commits here: 1411570
Comment #19
eliza411 commentedI'm really leery of organizing scenarios by their placement on the page, and I realize that's what was requested. This spatial organization is a small part, I think, of why the Scenario descriptions are hard to write in the language of the user ... I'm going to look at this more later, but in the meantime, the Scenario description should definitely reflect a user's voice, not a tester's. The user doesn't check to see things work, they try to use the links for a reason.
Comment #20
pradeeprkara commentedRearranged some of the scenarios to match display/how user reads it. As discussed followed the top to bottom approach here. (column-wise in content area)
Also corrected scenario descriptions. Probably we will need to remove using 'check' from descriptions and use 'view', 'visit' etc.
Please see the commits: 5137b0a, 5f02cc8
Comment #21
eliza411 commentedLooks like a good start to me. when you make those last few language changed, assign to tvn for review, please.
Comment #22
pradeeprkara commentedCorrected some of the scenario descriptions for other features as well, which were describing it from a tester's viewpoint.
Please review the changes.
http://drupalcode.org/project/doobie.git/commit/c6b4f8f
http://drupalcode.org/project/doobie.git/commit/d1f9b9e
http://drupalcode.org/project/doobie.git/commit/9fe145d
http://drupalcode.org/project/doobie.git/commit/0e04b88
The changes have been committed to 7.x branch as well.
Comment #23
pradeeprkara commentedassigning for review
Comment #24
tvn commentedI've updated frontpage_content.feature, added couple of scenarios. Please check that I didn't break anything, this file gives various errors when I'm trying to run it.
Also updated frontpage_footer.feature to check that footer is present on other pages as well.
http://drupalcode.org/project/doobie.git/commit/a631ad1
Overall I think these 3 files (header, content, footer) are complete. (Now only to make tests pass :) )
Comment #25
tvn commentedComment #26
eliza411 commentedThe tests pass on production; git6site appears to be broken still on most of these.
I won't be looking at them again against git6 but they will get picked up during the featureset review for 7.x
I'll be using a new issue to track 7.x so I'm marking this postponed. If anyone is inclined to continue work on the 6.x site feel free to take it on :)
Comment #27
pradeeprkara commentedUpdated descriptions, rerun and removed known_failure tag from some of the scenarios.
http://drupalcode.org/project/doobie.git/commit/a9aa21d
Comment #28
tvn commentedFixed indentation http://drupalcode.org/project/doobie.git/commit/43b37ab
Comment #29
pradeeprkara commentedPorted to 7.x.
http://drupalcode.org/project/doobie.git/commit/37afe15
http://drupalcode.org/project/doobie.git/commit/44e0362
http://drupalcode.org/project/doobie.git/commit/98fa170
Comment #30
tvn commentedSince we are not working on 6.x tests anymore - this issue should either be closed (if there is 7.x one) or moved to 7.x.
Comment #31
kssundar commentedThis now belongs to 7.x
Comment #32
eliza411 commentedMarking this postponed until the D7 Drupal.org upgrade status is known.
Comment #33
eliza411 commentedUpdated and working as expected.