Spin-off from #1215104: Use the non-interactive installer in WebTestBase::setUp()

Problem

  • Any call to drupal_cron_run() (re-)enables writing of the current $user's session.

Details

CommentFileSizeAuthor
#8 drupal7-cron_run_session_save-1688016-8.patch679 byteslucascaro
#6 drupal8.cron-run-session-save.6.patch699 bytessun
drupal8.cron-run-session-save.0.patch685 bytessun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Component: base system » cron system
lucascaro’s picture

lucascaro commented
Status: Needs review » Reviewed & tested by the community

Seems to be the right way to do it and it fixes existing problems at least with install_drupal :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -Needs backport to D7, -Testing system

drupal8.cron-run-session-save.0.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: +Needs backport to D7, +Testing system

drupal8.cron-run-session-save.0.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Looks fine but the variable name $old_save_session doesn't look right. Can we just call that $original_session or something?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new drupal8.cron-run-session-save.6.patch699 bytes

$original_session would be misleading, since the variable doesn't contain $_SESSION.

So I went with $original_session_saving.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Needs review » Patch (to be ported)

OK that works well enough, I can't think of anything better. Committed/pushed to 8.x, moving to 7.x for backport.

lucascaro’s picture

lucascaro commented
StatusFileSize
new drupal7-cron_run_session_save-1688016-8.patch679 bytes

Backported!

lucascaro’s picture

lucascaro commented
Status: Patch (to be ported) » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Hm. That variable name is indeed pretty terrible, but all the alternatives I can think of are 57-characters long and I know how you feel about those. ;P

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.