Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options: 

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: taxonomy/taxonomy.js

CommentFileSizeAuthor
#4 core-js-jshint-taxonomy.patch870 bytesnod_
#2 taxonomy-js.patch1.25 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented 
core/modules/taxonomy/taxonomy.js: line 32, col 20, 'n' is already defined.
droplet’s picture

droplet CreditAttribution: droplet commented
Status: Active » Needs review
FileSize
taxonomy-js.patch1.25 KB
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Needs work

For this one I'd rather change the variable name. That'd be better than reusing the same one in two unrelated loops.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Category: bug » task
Status: Needs work » Needs review
FileSize
core-js-jshint-taxonomy.patch870 bytes
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

works.

droplet’s picture

droplet CreditAttribution: droplet commented

Okay. RTBC to me too.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.