Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: [Meta] javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: contextual/contextual.js

Files: 
CommentFileSizeAuthor
#7 core-jshint-contextual-1684834-7.patch612 bytesnod_
PASSED: [[SimpleTest]]: [MySQL] 56,453 pass(es).
[ View ]
#4 contextual.jshint.patch1.33 KBdroplet
PASSED: [[SimpleTest]]: [MySQL] 54,784 pass(es).
[ View ]

Comments

droplet’s picture

Status:Active» Closed (won't fix)

No errors

nod_’s picture

Status:Closed (won't fix)» Closed (works as designed)
nod_’s picture

Status:Closed (works as designed)» Needs work

core/modules/contextual/contextual.js: line 106, col 24, Did you mean to return a conditional instead of an assignment?

droplet’s picture

Status:Needs work» Needs review
Issue tags:+Quick fix
StatusFileSize
new1.33 KB
PASSED: [[SimpleTest]]: [MySQL] 54,784 pass(es).
[ View ]
nod_’s picture

Status:Needs review» Closed (works as designed)

The contextual refactor fixed it.

nod_’s picture

Status:Closed (works as designed)» Needs work

And broke it again. New JSHint config #1995996: Update JSHint configuration.

core/modules/contextual/contextual.js: line 33, col 48, Missing semicolon.
nod_’s picture

Status:Needs work» Needs review
StatusFileSize
new612 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,453 pass(es).
[ View ]

this one makes me kind of sad actually.

droplet’s picture

Status:Needs review» Reviewed & tested by the community

Ouch!!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed f01622c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.