Hi, there seems to be a minor typo on testAuthUserUserLogin(). I see $this->DrupalGet in the function.

Files: 
CommentFileSizeAuthor
#1 1679584-1.patch967 bytesdsdeiz
PASSED: [[SimpleTest]]: [MySQL] 39,267 pass(es).
[ View ]

Comments

dsdeiz’s picture

Status:Active» Needs review
StatusFileSize
new967 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,267 pass(es).
[ View ]

Patch attached.

Devin Carlson’s picture

Status:Needs review» Reviewed & tested by the community

The patch in #1 applied cleanly and successfully changed the two occurrences of DrupalGet to drupalGet.

I performed a search through a fresh checkout of both Drupal 8 and Drupal 7 and was not able to find any occurrences of DrupalGet in Drupal 8 and only the two occurrences of DrupalGet that are covered by the patch in Drupal 7.

chx’s picture

For archives' sake, here's http://the-echoplex.net/log/php-case-sensitivity the PHP case sensitivy rules. Kinda nuts. I amended that post a little:

Case sensitive (both user defined and PHP defined)
variables
constants
array keys
class properties
class constants
Case insensitive (both user defined and PHP defined)
class names
functions
class methods (including the constructor)
keywords and constructs (if, else, null, foreach, echo etc.)
dsdeiz’s picture

Oh yeah. Was a little aware that methods were case insensitive. Was just wondering if it would somehow confuse other people. And it seems that that's the only function that has this very little typo. Anyway, just trying to keep it clean.

chx’s picture

Yes, consistent code style is very important and thanks for the patch, I posted #3 to make sure people understand why it didn't break.

webchick’s picture

Version:7.x-dev» 8.x-dev
Status:Reviewed & tested by the community» Needs work
Issue tags:+needs backport to D7

Nice find!

Can we get a quick re-roll for D8? Main difference is the /core subdirectory and the PSR-0 folder structure.

Devin Carlson’s picture

Version:8.x-dev» 7.x-dev
Status:Needs work» Fixed
Issue tags:-needs backport to D7

As per #2, I performed a search through a fresh checkout of Drupal 8 and was not able to find any occurrences of DrupalGet, so I think that this is fixed. :)

webchick’s picture

Oops! I didn't actually commit this to D7, cos I was waiting on a D8 patch first.

Now, though, it's fixed. :) Hooray!

Brought to you by the Mile High Committers Club™. Thanks, Alaska Airlines!

Automatically closed -- issue fixed for 2 weeks with no activity.