Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hi, there seems to be a minor typo on testAuthUserUserLogin(). I see $this->DrupalGet in the function.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1679584-1.patch | 967 bytes | dsdeiz |
Comments
Comment #1
dsdeiz commentedPatch attached.
Comment #2
devin carlson commentedThe patch in #1 applied cleanly and successfully changed the two occurrences of
DrupalGettodrupalGet.I performed a search through a fresh checkout of both Drupal 8 and Drupal 7 and was not able to find any occurrences of
DrupalGetin Drupal 8 and only the two occurrences ofDrupalGetthat are covered by the patch in Drupal 7.Comment #3
chx commentedFor archives' sake, here's http://the-echoplex.net/log/php-case-sensitivity the PHP case sensitivy rules. Kinda nuts. I amended that post a little:
Comment #4
dsdeiz commentedOh yeah. Was a little aware that methods were case insensitive. Was just wondering if it would somehow confuse other people. And it seems that that's the only function that has this very little typo. Anyway, just trying to keep it clean.
Comment #5
chx commentedYes, consistent code style is very important and thanks for the patch, I posted #3 to make sure people understand why it didn't break.
Comment #6
webchickNice find!
Can we get a quick re-roll for D8? Main difference is the /core subdirectory and the PSR-0 folder structure.
Comment #7
devin carlson commentedAs per #2, I performed a search through a fresh checkout of Drupal 8 and was not able to find any occurrences of
DrupalGet, so I think that this is fixed. :)Comment #8
webchickOops! I didn't actually commit this to D7, cos I was waiting on a D8 patch first.
Now, though, it's fixed. :) Hooray!
Brought to you by the Mile High Committers Club™. Thanks, Alaska Airlines!