At the moment, if i have configured a view with 10 rows - the export also will export 10 rows. I would expect an export to export all rows

regards
Christian

CommentFileSizeAuthor
#4 views_bonus_2.patch785 bytesrobloach
#2 views_bonus_export_allrows.patch874 bytesAnonymous (not verified)

Comments

robloach’s picture

robloach
he/him
commented
Category: feature » bug
Priority: Normal » Critical

Indeed, you're right. This is a major bug and should be fixed as soon as possible. It should export all rows in the views instead of just the "nodes per page" field.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new views_bonus_export_allrows.patch874 bytes

This patch will simply return all rows. When used with the filter arguments patch (http://drupal.org/node/175116) it seems to make more sense then imposing a different row limit just for exports. Excel has the row limit (65,536) so let it raise the error!

robloach’s picture

robloach
he/him
commented
Status: Needs review » Needs work

This makes sense if the view doesn't expect any other arguments. What happens, though, when you're using a view path like node/$arg/myview? Because then node/$arg/myview/csv doesn't have the new page limit of 0....

robloach’s picture

robloach
he/him
commented
StatusFileSize
new views_bonus_2.patch785 bytes

Does this do it?

Anonymous’s picture

Anonymous (not verified) commented

Yes, it does. Much better patch. Thanks!

robloach’s picture

robloach
he/him
commented
Assigned: Unassigned » robloach
Status: Needs work » Fixed

Grandola!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)